Giter VIP home page Giter VIP logo

Comments (5)

mrwyattii avatar mrwyattii commented on May 20, 2024 1

Hi @apoorvkh while in the past we have not required torch to be installed before installing DeepSpeed, it has always been required to run DeepSpeed. This "bug" is from a recent PR: #4547

It is problematic adding torch as a requirement to the project because pip will often install the CPU version rather than CUDA/ROCm versions.

We are discussing internally what the proper action is, but I suspect we will restore the previous behavior of not requiring torch at install time and do a 0.13.1 patch release with this update.

from deepspeed.

apoorvkh avatar apoorvkh commented on May 20, 2024

cc @mrwyattii @jeffra

from deepspeed.

apoorvkh avatar apoorvkh commented on May 20, 2024

Understood, that would be great -- thank you!

from deepspeed.

delock avatar delock commented on May 20, 2024

This issue is caused by these two piece of reflection codes. The problem is the reflection code should not intend to iterate into directories belongs to other accelerator.

https://github.com/microsoft/DeepSpeed/blob/master/op_builder/__init__.py#L46
https://github.com/microsoft/DeepSpeed/blob/master/op_builder/all_ops.py#L22

There are two possible fixes, one is to skip directories belongs to accelerators with code like:
if module_name not in ['cpu', 'hpu', 'mps', 'npu', 'xpu']:
Another possible fix which is more graceful should be move CUDA OpBuilders into cuda/ directory in op_builder but his might need more global code change.

from deepspeed.

apoorvkh avatar apoorvkh commented on May 20, 2024

Everything is working well on my end -- thanks again @mrwyattii!

from deepspeed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.