Giter VIP home page Giter VIP logo

Comments (5)

FlorianPydde avatar FlorianPydde commented on May 20, 2024

Michel you are absolutely right. There are nevertheless slight differences in the code logic for retrieve_workspace for instance.
When we run code from the operation folder, we assume the code will be run in a devops pipeline, which means we will use Service Principals to connect to the AML workspace. Whereas, when running the code from src, the scripts will either be run locally or on a experiment run.

There was a similar discussion here. The problem is not so straightforward to solve but we are eager to get your inputs 😃 Do you have any suggestions ?

from dstoolkit-mlops-base.

mariamedp avatar mariamedp commented on May 20, 2024

I agree as well. The main reason that's preventing us from putting everything together is that only the src/ folder is uploaded to the compute cluster for execution during training/batch inference, and hence we need some AML utilities there. Maybe we can look at simplifying src/utils.py at maximum? And/or change the function names to make them more descriptive of the differences?

from dstoolkit-mlops-base.

michelole avatar michelole commented on May 20, 2024

Since this also seems to be duplicated among templates (and potentially among their implementations), I'd favor moving this upstream.

Maybe we should then keep the discussion on the linked thread? Tentatively closing then.

from dstoolkit-mlops-base.

michelole avatar michelole commented on May 20, 2024

If there's a decision not to upstream it, we could explore removing the duplicate at least in this repo by:

  1. declaring and building a package with all "utils" code
  2. publishing it via a private Python package
  3. installing it via pip/conda in the remote compute instance.

from dstoolkit-mlops-base.

FlorianPydde avatar FlorianPydde commented on May 20, 2024

The private package option would be a good alternative to reduce code duplication. Nevertherless, there is work in progress for the next release of the aml sdk (here an example regarding pipelines: azureml-previewss) which will probably require some adjustments to the solution. Hence, I would suggest keeping it simple and accessible (vs a package) even though it means having some duplicated code.

from dstoolkit-mlops-base.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.