Giter VIP home page Giter VIP logo

Comments (4)

ykim362 avatar ykim362 commented on July 28, 2024

Hi @jmwoloso.

Thanks for your interest in FastFormers! There's one assumption that is not valid for head pruned attention modules. (hidden_size != head_size * num_heads, because head_size is fixed and some heads are pruned. So, num_heads is now smaller than the original value.). There seem to be a few places in HF transformers which rely on this assumption.

If you could cherry-pick the changes in modeling_bert.py and configuration_bert.py from the PR in HR repo, you might be able to execute the fastformers example script.

Hope this answers your question. And, please let me know if you have any other questions. Thanks!

from fastformers.

jmwoloso avatar jmwoloso commented on July 28, 2024

Thanks for the reply @ykim362! That's pretty interesting. I'm still reading through the paper, but is that the only real hangup preventing your work from being merged to Transformers?

from fastformers.

ykim362 avatar ykim362 commented on July 28, 2024

@jmwoloso that was a major blocking issue. The other things are more about pipelining of datasets based on applications which also need some work. But, those are more related to the applications.

from fastformers.

jmwoloso avatar jmwoloso commented on July 28, 2024

ok, thank you for the detail @ykim362!

from fastformers.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.