Comments (2)
I will hold this one for 1.0.0
release. Let's discuss after that.
from fluentdarkmodekit.
Let's start working on this. The proposed API looks good to me, since we are working to mimic the official APIs, this looks like the closest we can get.
In addition to that, we can probably also forward our current light/dark color init method to the one based on DynamicProvider
- (instancetype)initWithLightColor:(UIColor *)lightColor darkColor:(UIColor *)darkColor {
return [self initWithDynamicProvider:^UIColor *(DMTraitCollection *traitCollection) {
if (traitCollection.userInterfaceStyle == DMUserInterfaceStyleDark) {
return darkColor;
}
else {
return lightColor;;
}
}];
}
What do you think? @icodesign @kylinroc
from fluentdarkmodekit.
Related Issues (20)
- `dmTraitCollectionDidChange(_ previousTraitCollection: DMTraitCollection?)` not called HOT 2
- Memory HOT 11
- Dark mode in HTML HOT 1
- 'FluentDarkModeKit/FluentDarkModeKit-Swift.h' file not found HOT 5
- iOS12 UIButton HOT 1
- WidgetExtension #error unsupported Swift architecture HOT 8
- Error pod install HOT 4
- Remove git-lfs? HOT 12
- Project does not build once added. HOT 2
- Bundle SwiftLint inside the project? HOT 4
- Does it support layer? HOT 4
- The minimum supported version. HOT 1
- Migrate to system API on iOS 13 HOT 2
- How to use ? HOT 4
- Usability in Objective-C only Projects HOT 1
- Tabbar can not change HOT 2
- Bug:objc_retain + 16 HOT 4
- Namespace style HOT 5
- Sometimes Without UIScence
- Version not released in CocoaPods HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluentdarkmodekit.