Sanity check creation of summarizer client around disconnected states. about fluidframework HOT 3 CLOSED

Related to #198. This issue will be for adding additional telemetry and analysis.

We should consider calculating the number of simultaneous summarizers on a document based on documentId, clientId, and timestamps of Summarizer events, because it might be more objective and still useful. I have added clientId to summarizer events in PR #208.

from fluidframework.

Answering original questions with more information:

1. Do we destroy summarizing container on lost connection?
   a) When the parent container disconnects, it will now stop the summarizer which will close its container. (PR #208 addresses issue #198)
   b) When the summarizer itself disconnects, it will resolve its run promise, which should essentially kill the container since reconnect is false, and its creator (SummaryManager from parent container) will no longer reference it.
2. Do we always recreate summarizer on same client on reconnect if there were (and there are) no other clients connected?
   a) Any time the quorum addMember event fires, all clients recompute the summarizer. This should generally relaunch the summarizer if it has stopped.
   b) If only the summarizer itself disconnects, then I believe the parent will not restart the summarizer, because it will believe that it already has a summarizer running. This needs to be resolved.

My idea for resolving 2.b is to clean up the SummaryManager logic for detecting if it is already summarizing, and add code to try to recompute the summarizer if the summarizer run promise is fulfilled (indicating summarizer container disconnected).

The reason 2.b is a special case, is because if the parent container also disconnects/reconnects, it will "force" compute summarizer even if the thing it uses to track whether it is already summarizing or not indicates that it already has a summarizer. This is correct under the current conditions, because it only does this "force" on connect, which means that it was previously disconnected, and it won't start a summarizer when disconnected, and will stop the summarizer on disconnect.

from fluidframework.

Also PR #362 is related.

from fluidframework.