Aqueduct components can only be created by other Aqueduct components... about fluidframework HOT 5 CLOSED

Yea. This is predicated on the fact that if you implement IComponentForge someone needs to forge you before they attach you. I had a pr https://github.com/microsoft/Prague/pull/2993 to push the forging logic into the runtime but it got some push back and I haven't got back around to looking at it.

Overall there's a question of:

What happens if you are creating a component that requires some props as part of creation?

Options that I've considered:

1. instantiateComponent takes a props somehow (passed in via IComponentContext or an additional property). This is similar to how we pass the isExisting flag currently. our createComponent(id, pkg, props?) and the props would be passed into the instantiateComponent call. The developer would then need to know to look for those props and pass them into their constructor or initialize step appropriately.

2. instead of just having an instantiateComponent call we could have two. instantiateComponent and createComponent that the developer has to implement and we call them depending on if it's the first time or not. I don't like this because I feel like it's a lot of extra work on the developer.

3. We have a pattern where the caller is required to call forge(props) after creation. This is what we went with but since there is not compile time break it's easy to mess up. If we want to continue with this path we should make it part of the runtime.

I like 1 & 3 and have been leaning back and forth.

from fluidframework.

I'd recommend option 1. You'll then no longer need the IComponentForge interface.

from fluidframework.

@DLehenbauer , yea I agree.

from fluidframework.

@skylerjokiel is this still relevant since forge was removed?

from fluidframework.

This issue is resolved now.

from fluidframework.