Decouple ISegment from BaseSegment about fluidframework HOT 7 CLOSED

This microsoft/Prague#1482 will be difficult without this proposal

from fluidframework.

@steveluc & @DLehenbauer I'd be curious to know your thoughts on this proposal

from fluidframework.

It's a clever observation that if ISegment itself were JSON serializable we wouldn't need custom serializers/deserializers. I think much of the required factoring to enable this would be very positive (e.g., MergeTree only speaks ISegment), but I'm skeptical that avoiding the need for custom serializers/deserializes is worth the tradeoffs this would bring between compressing in-memory representation (i.e., Zamboni) and compressing the wire-format.

(Just my initial reaction. Feel free to persuade me if you see a strong upside.)

from fluidframework.

Getting rid of serializers/deserializers and making ISegment JSON serializable is one possible implementation, but we could also keep them, and allow them to run client side. This would keep wire format compression, but potentially lose some representational compression. This probably needs deeper investigation. My guess is that a hybrid approach is probably best here. We'll keep some segment types in the runtime for both advantages, but allow custom types that forego either or both levels of compression for the flexability of using custom types.

You bring up a good point in that whether the snapshotter needs them or not is an orthogonal problem to the design issue around the simplification of ISegment. In fact doing the decoupling would make it easier to explore. It seems like you agree that this would be a good change to pursue, and we can wait to decide the serde issue afterwards

from fluidframework.

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

from fluidframework.

i would still like to do this.... someday, so go away bot.

from fluidframework.

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

from fluidframework.