Giter VIP home page Giter VIP logo

Comments (4)

andrueastman avatar andrueastman commented on June 2, 2024

Thanks for raising this @andnorxor

I believe this is probably an issue with the input openApi file in use. Any chance you can confirm/share if the Path /users/getByIds in openApi contains a $select parameter?

from kiota.

andnorxor avatar andnorxor commented on June 2, 2024

Any chance you can confirm/share if the Path /users/getByIds in openApi contains a $select parameter?

Yes. Can confirm.

The following is the official openapi spec I've downloaded with kiota download github::microsoftgraph/msgraph-metadata/graph.microsoft.com/v1.0 --output msgraph-openapi.yaml

It is missing any $select parameters.

The documentation also states:

Return the directory objects specified in a list of IDs. Only a subset of user properties are returned by default in v1.0.

It seems that this is an undocumented feature. POST https://graph.microsoft.com/v1.0/users/getByIds?$select=id,identities

IMO: This issue can be closed, or treated as feature request given that the logic is already implemented at the API level.

/users/getByIds:
    description: Provides operations to call the getByIds method.
    post:
      tags:
        - users.Actions
      summary: Invoke action getByIds
      description: 'Return the directory objects specified in a list of IDs. Only a subset of user properties are returned by default in v1.0. Some common uses for this function are to:'
      externalDocs:
        description: Find more info here
        url: https://learn.microsoft.com/graph/api/directoryobject-getbyids?view=graph-rest-1.0
      operationId: users.getByIds
      requestBody:
        description: Action parameters
        content:
          application/json:
            schema:
              type: object
              properties:
                ids:
                  type: array
                  items:
                    type: string
                types:
                  type: array
                  items:
                    type: string
                    nullable: true
        required: true
      responses:
        2XX:
          description: Success
          content:
            application/json:
              schema:
                title: Collection of directoryObject
                type: object
                allOf:
                  - $ref: '#/components/schemas/BaseCollectionPaginationCountResponse'
                  - type: object
                    properties:
                      value:
                        type: array
                        items:
                          $ref: '#/components/schemas/microsoft.graph.directoryObject'
        4XX:
          $ref: '#/components/responses/error'
        5XX:
          $ref: '#/components/responses/error'
      x-ms-docs-operation-type: action
      x-ms-pageable:
        nextLinkName: '@odata.nextLink'
        operationName: listMore

from kiota.

andrueastman avatar andrueastman commented on June 2, 2024

Thanks for confirming @andnorxor

As the openApi description is missing the query parameters in the POST method, Kiota will not be able generate the parameters that are not defined.

Any chance you can create an issue here so that the metadata can potentially be looked into getting updated? https://github.com/microsoftgraph/msgraph-metadata

from kiota.

andrueastman avatar andrueastman commented on June 2, 2024

Closing this for now as issue exists at microsoftgraph/msgraph-metadata#495

from kiota.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.