Giter VIP home page Giter VIP logo

Comments (7)

sebastienlevert avatar sebastienlevert commented on September 13, 2024 1

I'll jump in on this one. I don't think the goal is to get an OpenAPI document with only the right endpoints. I think the goal is to reuse a similar logic to the one built for plugins instead of having 2 different logic that do very similar things, without being reused. I agree with @baywet, we should absolutely not replace the OpenAPI we cache with a sliced version of it or we'll lose the possibility to expand its capabilities.

from kiota.

baywet avatar baywet commented on September 13, 2024

Is this for the kiota folder? We should always keep the original description in case the user wants to change their selection IMHO

from kiota.

andrueastman avatar andrueastman commented on September 13, 2024

@baywet This is still unclear. This issue was created to split out #4672 to only work for plugins generation as the questions on functionality in client generation is cleared up.

from kiota.

baywet avatar baywet commented on September 13, 2024

@maisarissi to provide additional input

from kiota.

maisarissi avatar maisarissi commented on September 13, 2024

That's was exactly my intention, not replacing the copy of the OpenAPI document, but since client generation does "go through" a similar logic as the slicing logic we have for plugins, why not reuse it for client generation, having the slicing logic and then generating the client based on that? Instead of generating all models and then deleting the ones that are not referenced?

from kiota.

baywet avatar baywet commented on September 13, 2024

where would you place this new sliced description? for plugins it makes sense since it's required by the "engine". For clients we could place it next to the Client class. Thoughts?

from kiota.

sebastienlevert avatar sebastienlevert commented on September 13, 2024

In the output folder as an openapi.yaml file would be optimal. That way it live with the code.

from kiota.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.