On Arch Linux, ARM 32 bit: <div class="snippet-clipboard-content notranslate posit

Fails to compile on ARM Linux about mimalloc HOT 5 CLOSED

microsoft commented on May 16, 2024

Fails to compile on ARM Linux

from mimalloc.

Comments (5)

daanx commented on May 16, 2024 1

Good to hear! -- I'll look into doing efficient thread id detection on ARM (any pointers are appreciated).

from mimalloc.

daanx commented on May 16, 2024

Ah, never tried building on ARM yet. I just pushed a possible fix to master -- can you try that?

Beyond that, the code at:
https://github.com/microsoft/mimalloc/blob/master/include/mimalloc-internal.h#L288

uses special casing to efficiently get a thread unique id. I am sure ARM will have this too and it we should add such case (for best performance).

from mimalloc.

stronnag commented on May 16, 2024

Thanks for the amazingly fast reply; the compile error moves on:

Scanning dependencies of target mimalloc-static
[  4%] Building C object CMakeFiles/mimalloc-static.dir/src/stats.c.o
In file included from /home/jrh/Projects/mimalloc/src/stats.c:8:
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h: In function ‘mi_get_default_heap’:
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:156:10: error: ‘_mi_’ undeclared (first use in this function); did you mean ‘_mi_bsr’?
   return _mi_
          ^~~~
          _mi_bsr
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:156:10: note: each undeclared identifier is reported only once for each function it appears in
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:156:14: error: expected ‘;’ before ‘ault’
   return _mi_
              ^
              ;
   ault;
   ~~~~        
make[2]: *** [CMakeFiles/mimalloc-static.dir/build.make:63: CMakeFiles/mimalloc-static.dir/src/stats.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:73:

from mimalloc.

daanx commented on May 16, 2024

Argh, accidental mistake in the fix. Can you try again?
(and from now I will switch to the dev branch for quick fixes :-) )

from mimalloc.

stronnag commented on May 16, 2024

Building (and running) --- thanks.

from mimalloc.

Recommend Projects