R if in for loop error - how can I save selected model? about ml-for-beginners HOT 5 CLOSED

Thanks Eric, Apologies for the hassle with a tiny mistake. It took me a lot of time to figure it out! Kind regards, Tom From: Eric ***@***.***> Sent: Saturday, 26 February 2022 8:20 PM To: microsoft/ML-For-Beginners ***@***.***> Cc: Hyong Doo Jang ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/ML-For-Beginners] R if in for loop error - how can I save selected model? (Issue #539) Hello @TomJang<https://github.com/TomJang>, Firstly, thank you for providing a reproducible example. You were almost there, so good job! The only thing that was missing is evaluating for a second condition, i.e if lm.cv.r[i] > 0.70. I have modified your example and it works as expected: data("USArrests") head(USArrests) df.norm <- USArrests set.seed(100) lm.cv.mse <- NULL lm.cv.r <- NULL k <- 100 for(i in 1:k){ index.cv <- sample(1:nrow(df.norm),round(0.8*nrow(df.norm))) df.cv.train <- df.norm[index.cv, ] df.cv.test <- df.norm[-index.cv, ] lm.cv <- glm(Rape~., data = df.cv.train) lm.cv.predicted <- predict(lm.cv, df.cv.test) lm.cv.mse[i] <- sum((df.cv.test$rape - lm.cv.predicted)^2)/nrow(df.cv.test) lm.cv.r[i] <- as.numeric(round(cor(lm.cv.predicted, df.cv.test$Rape, method = "pearson"), digits = 3)) if (!is.na(lm.cv.r[i]) && lm.cv.r[i] > 0.70){ saveRDS(lm.cv, file = paste("lm.cv", i, lm.cv.r[i], ".rds", sep = '_')) } } — Reply to this email directly, view it on GitHub<#539 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALVVLRWWJ7E7LHO4MANQAMDU5DAQVANCNFSM5PDDBC4Q>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>