Giter VIP home page Giter VIP logo

Comments (4)

chrisfenner avatar chrisfenner commented on May 17, 2024

Failing test cases are commented out in this block of tests for go-tpm's PolicyNV implementation:

https://github.com/chrisfenner/go-tpm/blob/544f65a994f1e36dae02e8f00adb60cc804bae07/tpm2/test/tpm2_test.go#L1575-L1599

from ms-tpm-20-ref.

chrisfenner avatar chrisfenner commented on May 17, 2024

An alternative solution I can see is to just roll with the behavior and update the spec to require signed-magnitude behavior here instead of twos-complement. However, the code as written will consider 0 and "negative 0" (0x80..00) not to be equal, so there is still a (more minor) implementation bug we should address.

from ms-tpm-20-ref.

josephlr avatar josephlr commented on May 17, 2024

@chrisfenner I think this can be closed. Given that f16879b fixed the issue.

from ms-tpm-20-ref.

chrisfenner avatar chrisfenner commented on May 17, 2024

@josephlr You're right. I had thought "well, this can help track the errata/regression test work" but that tracking belongs inside TCG.

from ms-tpm-20-ref.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.