[Parser] Support `del` about onnxscript HOT 5 OPEN

cc @gramalingam

from onnxscript.

Supporting it in onnxscript should be doable. (Though, to be complete, the converter should also check that what is deleted is not used subsequently, and produce an error message if it is used.)

However, from the aten-library perspective, I am not sure if adding the dels are that useful. It seems to me that their primary value is in enabling a garbage collector to collect large data-structures. I am not convinced about its use for documenting unused arguments. Further, it seems a bit artificial in this example, the arguments should really be used. The underlying issue may be something else.

from onnxscript.

SGTM. How does

_ = scale

look to you? Assuming the example and ignoring the actual underlying issue.

from onnxscript.

SGTM. How does

_ = scale

look to you? Assuming the example and ignoring the actual underlying issue.

This will be translated, as of now, into an ONNX node that constructs a constant representing the value of scale, which is something we would not want in the generated function.

I would like to understand the requirement here. Is the goal to document that this is an unused argument? That can be done using comments, if the target is a human-reader, and I think that is a preferable solution. If it is to use del because that is used by some tools, that's a different story, and we can support del directly instead of a statement like the above.

from onnxscript.

It's mostly for tools. Seen in https://google.github.io/styleguide/pyguide.html#214-decision "Unused argument warnings..."

Looks like assigning to _ is discouraged so nvm. I am happy to disable this rule and leave the arguments unused too. If we wanted to follow the recommendation from this guide, then del is the way to go

from onnxscript.