Giter VIP home page Giter VIP logo

Comments (3)

garymm avatar garymm commented on August 22, 2024

Fixed by #15?
If not, what is left to do?

from onnxscript.

gramalingam avatar gramalingam commented on August 22, 2024

I think the following needs to be done (mostly to ensure consistency between eager-mode and onnx-conversion):

  • Will need type-checking to ensure types of arguments passed in (for eager-mode) are of correct expected types
  • This will be better off if we define our own types/classes (e.g. our own tensor-types, that may be a wrapper around numpy arrays) and if these are consistent with the type-annotations we use (such as FLOAT[100]). At any rate, we should have a clear definition of what representation-type we use for what onnx-types.

Further, we should be able to do the following (not sure it is there yet): simply import the function-definitions, and call them as normal python functions. Just like in the example shown above for gemmgelu, but I think some clean up may be required (such as special handling of the identifier oxs etc.)

from onnxscript.

justinchuby avatar justinchuby commented on August 22, 2024

Looks like this is done.

from onnxscript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.