Comments (4)
where we compare actual files with the current existing ones.
In which directories are you comparing them? We did a change but this should only have affected the test-results
directory, not the actual golden test expectations on disk. I tried to reproduce it on my machine, and there it was working as expectd (only test-results
have changed).
// 1.42 /Users/maxschmitt/Developer/tmp/1510/test-results/project1-Here-is-a-test-with-a-very-long-title-5bd13-long-title-tlong-title-to-reproduce-the-problem-test
// 1.43 /Users/maxschmitt/Developer/tmp/1510/test-results/project1-Here-is-a-test-wi-5bd13-le-to-reproduce-the-problem-test
Do you consume them via test.info().outputDir
or via the reporting api?
from playwright.
Yes, we use the files outputted in the test-results
folder. We have an manual approval step on failed test runs on CI, that if approved, runs a script that compare file names and update the golden snapshots using the actual ones from test-results
.
Can you please confirm that this change is only affecting file names?
from playwright.
It only affects the test-results directory which is not intended to be consumed directly. Its intended to be consumed via our APIs, either inside a test via test.info().outputDir
or via the reporter API.
from playwright.
Yes, we use the files outputted in the test-results folder. We have an manual approval step on failed test runs on CI, that if approved, runs a script that compare file names and update the golden snapshots using the actual ones from test-results.
As Max mentioned you can implement a custom reporter and access all the images including their paths via TestResult.attachments
. The exact naming of the paths in toHaveScreenshot
is an implementation detail and it can change between versions.
Can you please confirm that this change is only affecting file names?
The change affected file names of the diff and actual images. Actual snapshot name stays the same. It can
from playwright.
Related Issues (20)
- [Docs]: `echo "\nplaywright/.auth" >> .gitignore` is incorrect for Bash HOT 5
- Hello Folks, Is their any way to provide the UI element in headless mode and return a locator for the same. HOT 1
- [Docs]: typo: "it's" should be "its" HOT 1
- [Feature]: Ability to take screenshots during codegen HOT 1
- [Bug]: When loading `storageState` the extension don't loads in the chromium browser HOT 3
- In which cases we can get Playwright detected inconsistent test.use() options. HOT 10
- [Bug]: WebKit Build (v2003): Spreading class instances causes result not to be a plain object (but instances of the original class) HOT 2
- [Bug]: Trace network start time shows end time instead of actual start time HOT 1
- [Bug]: getByRole with combobox and name does not work
- [Bug]: Crashed playwright has open handles HOT 6
- [Bug]: `_frame` undefined when calling Playwright action as function argument HOT 2
- [Bug, Regression]: Dynamic Import of ES Module fails in Playwright v1.44.1 and 1.43.1 (works in v1.42.1 and below) HOT 1
- [Bug]: Console error not reported HOT 1
- [Regression]: Self signed certificate now produces ERR_SSL_KEY_USAGE_INCOMPATIBLE HOT 7
- Error occurred in lambda: Page.goto: Target page, context or browser has been closed HOT 1
- [Bug]: VS Code extension no longer picking up .env variables. HOT 2
- [Feature]: To add the failure screenshot into the report folder HOT 2
- [Bug]: Compiler errors about Property 'asyncDispose' does not exist on type 'SymbolConstructor' after updating playwright/test to 1.40 HOT 3
- [Bug]: VS-Code plugin restarts multiple time with multiple browsers HOT 1
- [Bug]: When emulating iOS devices, WebKit orientation is always landscape-primary.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playwright.