APIScan: Microsoft.ReactNative.dll gives "Duplicate Function Names Defined" errors in `microsoft.reactnative.cxx\desktopwindowbridge.h` about react-native-windows HOT 5 CLOSED

Resolution information: https://eng.ms/docs/products/apiscan/troubleshooting/errorcodes/duplicatefunctionnamesdefined

from react-native-windows.

Checking in main (and 0.70-stable), it appears we're making indirect calls to:

• user32.dll!GetWindowRect()
• user32.dll!GetDpiForWindow()
• shell32.dll!SHGetKnownFolderPath()

via the CALL_INDIRECT macro in DesktopWindowBridge.h.

from react-native-windows.

Here is the documentation for the APIs we're using:

• user32.dll!GetWindowRect(): https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindowrect
• user32.dll!GetDpiForWindow(): https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getdpiforwindow
• shell32.dll!SHGetKnownFolderPath() https://learn.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetknownfolderpath

from react-native-windows.

Need to address as is for now. But its worth evaluating why we call these indirectly and whether we need to still do that.

It was added 2 years ago for this change: WinUI 3 DesktopBridge by asklar · Pull Request #7135 · microsoft/react-native-windows (github.com)

Which indeed, has these callsites that match below: Code search results: CALL_INDIRECT (github.com)

from react-native-windows.

This issue has been resolved via ICM Incident 457752604 (Internal Only).

from react-native-windows.