sbom-tool generate -ManifestDirPath _manifest creates nested directory about sbom-tool HOT 4 CLOSED

We create the _manifest directory automatically. You don't have to specify the _manifest directory yourself. You can just specify the directory where you want the SBOM to be stored in that parameter, so in this case the net6.0 directory.

from sbom-tool.

I was just trying to say that from a first-user perspective, the creation of the _manifest directory is somewhat unexpected (actually, the creation of any directory is unexpected to me). Because the argument name kinda leads one to assume that the value we set will be the final directory, and the manifest would be placed immediately there; but instead, we find the actual manifests in a two-level depth directory.

from sbom-tool.

@aasim This is the exact same issue I mentioned from here in that email thread: https://github.com/microsoft/dropvalidator/issues/498

I'm telling ya, the description of that parameter is extremely misleading. It really shouldn't be generating a _manifest directory, and wasn't doing this prior to the changes in June. I 100% agree with @rgl here that the documentation needs updated if this is intended.

Edit: Here's the code that is doing this action:

The code using this is right above it:

It is saying that if you provide a ManifestDirPath, then append _manifest to the path. But I can't understand why this is necessary?

from sbom-tool.

@aasim , should we just update the documentation?

from sbom-tool.