Comments (4)
I think this is easily doable, but it breaks the abstraction around the IO generator -- it would lead to recipes that only work with DiskSpd and not SQLIO, for example. (Or perhaps more realistically, if someone ports StorScore to linux and adds fio support). Maybe that's fine.
from storscore.
It might help to have a flag to explicitly mention which IO_generator is needed for the recipe. Something like
...
io_gen_args => "-r8k ",
io_gen => diskspd
...
This way the code could fail, saying "IO generator inconsistency" instead of whatever the IO generator does with a different generator's args.
I'll have to think about how the IO-gen on the command line vs. in the recipe will work...
from storscore.
You could just wrap the test in "if( $cmd_line->io_generator eq 'diskspd' )" and it would be silently ignored in the other cases. I think we once had some recipes that did this.
from storscore.
ah, I like it!
from storscore.
Related Issues (20)
- Add OS Version
- Latest version of Perl don't work HOT 2
- Enable purge for a striped volume
- Make cmd_line writable from Recipe HOT 2
- Enable Multiple Targets
- 4k_RR Recipe inconsistency HOT 5
- 4K Read and Write recipes HOT 5
- Need Help with Maxpower recipe HOT 1
- Increase number of Queues HOT 1
- Not generating proper results HOT 5
- Download file code issue
- StorScore drive prep & preconditioning HOT 8
- warn_illegal_args fix HOT 14
- DiskSpd returned non-zero errorlevelOut of memory! HOT 11
- Reported partition size always defaults to user capacity when target is physical drive number HOT 1
- Could not open file '.....\results\...\logman-raw-....csv' No such file or directory HOT 1
- StorScore Corners recipe creates disk corruption messages in eventvwr during purge phase HOT 5
- question about initialize step
- Specifying output path HOT 1
- This repo is missing important files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storscore.