Giter VIP home page Giter VIP logo

Comments (4)

marksantaniello avatar marksantaniello commented on May 16, 2024

I think this is easily doable, but it breaks the abstraction around the IO generator -- it would lead to recipes that only work with DiskSpd and not SQLIO, for example. (Or perhaps more realistically, if someone ports StorScore to linux and adds fio support). Maybe that's fine.

from storscore.

lauracaulfield avatar lauracaulfield commented on May 16, 2024

It might help to have a flag to explicitly mention which IO_generator is needed for the recipe. Something like

...
io_gen_args => "-r8k ",
io_gen => diskspd
...

This way the code could fail, saying "IO generator inconsistency" instead of whatever the IO generator does with a different generator's args.

I'll have to think about how the IO-gen on the command line vs. in the recipe will work...

from storscore.

marksantaniello avatar marksantaniello commented on May 16, 2024

You could just wrap the test in "if( $cmd_line->io_generator eq 'diskspd' )" and it would be silently ignored in the other cases. I think we once had some recipes that did this.

from storscore.

lauracaulfield avatar lauracaulfield commented on May 16, 2024

ah, I like it!

from storscore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.