Comments (6)
Understood. I would still suggest removing as AuthKeys, no matter what they're for, should not be hard-coded.
from tailwindtraders-backend.
Hi!
This is the authkey used by the CosmosDB emulator (on Windows).
The assumption (should be docummented) here is that if AUTHKEY
is not set is because you are using CosmosDb emulator.
Need to document how to develop on local machine using CosmosDb emulator and Docker or Visual Studio, because is not a easy setup.
Thanks! :)
from tailwindtraders-backend.
You're true on this.
Just pointing that, at least, this hardcoded key is not a security issue. But it can be easily handled through .env
file on Backend site.
I'll keep this issue open until this is fixed!
from tailwindtraders-backend.
It's not a security issue for you, but for the customers that look at this and say "ah - here's a pattern we can follow", it becomes a security issue for them. It's super important we follow our own guidelines no matter how good we think our practices are - users look to our code and often will copy/paste, which is fine as that's why it's there.
from tailwindtraders-backend.
Hi @robconery
I've updated the code and added documentation about how to configure containers for running locally.
I leave the issue open, close it if this is OK.
from tailwindtraders-backend.
Fixed with commit d9bbee
from tailwindtraders-backend.
Related Issues (20)
- Instead of Service Principles passwords/certificates, Managed Identities
- CD is failing
- Nightly build and deploy failing
- 503 error on successful deployment of webbff service HOT 3
- Many images do not build with docker build HOT 3
- [PopularProducts.Api] Docker build failure on Docker file HOT 1
- Rewards DB values not populated by token-replace.ps1 HOT 2
- CashLoopBackoff after Application Insights additions HOT 4
- Missing product images HOT 2
- Deploy to Azure button fails HOT 3
- Error: unknown shorthand flag: 'e' in -encodedCommand HOT 2
- Generate-Config.ps1: Command 'az cosmosdb list-keys' has been deprecated HOT 1
- Generate-Config.ps1: App Insights Instrumentation Key is output twice, unnecessary HOT 2
- Generate-Config.ps1: Output of "App Insights Instrumentation Key" in the tokens section HOT 1
- Deploy-Images-Aks.ps1: Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Deployment" in version "apps/v1beta2" HOT 1
- Enabling SSL/TLS on the cluster related issues HOT 2
- Join-Path-Recursively Error HOT 1
- Unified setup does not deploy services to k8s HOT 1
- The Deploy templates fail as the JSON references /master/ and yet the path is changed to /main/ HOT 1
- Debug in Visual Studio 2019 with Docker-Compose Fails HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tailwindtraders-backend.