Comments (11)
The actual behavior here matches the spec. It appears to be by design.
from typescript.
Another interesting example where we don't error, but probably should:
var v: { [s: string]: string} = {
p: 3, // Expect an error here
q: null
}
This is a result of best common type losing information, and the nontransitivity of assignability.
from typescript.
What's the action here? If we're aligned to spec, shouldn't this just be closed as by design?
from typescript.
As I recall from discussion, the spec needs to be updated to align with the current behavior. Specifically, I think section 3.8.1 needs to not pull in call/construct/index signatures for the augmented types.
And it is a breaking change.
from typescript.
I'm confused. You mention earlier that the "actual behavior here matches the spec. It appears to be by design." If so, is there a spec change?
from typescript.
Yeah my previous comments were wrong because I misunderstood what was going on. Ignore those. It needs a spec change per my recent comment.
from typescript.
Before we make this change, please confirm that the change does not impact real world code before we make the spec change.
from typescript.
Reopening this because the validation on real world code was not done yet.
from typescript.
Doesn't break any real world code we know of.
from typescript.
Is this fixed, or by design?
from typescript.
Fixed, in that it is a change from the old compiler. Spec has been updated to reflect behavior of the new compiler.
from typescript.
Related Issues (20)
- Iterator and AsyncIterator missing Symbol.dispose method in esnext.disposable
- tsc compiler crash on complex project (with tons of tests) HOT 6
- Using @ts-expect-error on class method signature would disable checking all other methods in interface HOT 2
- Sometimes inlay hints disappear when Vue source code contains a special custom component. HOT 2
- When combining the same type, the specific type before combining is still provided HOT 1
- getSymbolAtLocation(node: Identifier) return undefined, in WatchCompilerHost, after change dependency source file
- [Regression] Circular reference error when passing a class expression with non-primitive static properties to a generic function
- [NewErrors] 5.6.0-dev.20240714 vs 5.5.3 HOT 9
- [ServerErrors][JavaScript] 5.6.0-dev.20240714 vs 5.5.3 HOT 13
- [ServerErrors][TypeScript] 5.6.0-dev.20240714 vs 5.5.3 HOT 21
- spread operator infer to wrong type with method override and generic HOT 6
- Intellisense is slow and some things don't work HOT 7
- TS error moving a function to another file HOT 1
- Constructor cannot access own protected instance when typed as union HOT 3
- This comparison appears to be unintentional because the types 'U[K]' and 'T[K]' have no overlap.ts(2367) HOT 3
- [isolatedDeclarations] Optional parameter in arrow function typed as imported generic type gets emitted as `any`
- Easier use of indexed access types on nullable/optional types HOT 2
- Narrow conditional type HOT 1
- Error for path not found when ended with asterisk
- `tryGetPerformanceHooks` throws on Stackblitz with ts 5.5.3 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.