Comments (2)
I would love to see some clarification on what you guys think is the correct behaviour so that we can follow-suit!
I have no idea and I don't think it's likely that a poll of developers would produce a strong majority outcome either. It seems much more clarifying to either write
/** @deprecated */
namespace Foo1 {
export namespace Bar {
export const x = 1;
}
}
or
namespace Foo1 {
/** @deprecated */
export namespace Bar {
export const x = 1;
}
}
depending on which is intended (hopefully they both work more consistently?)
A PR to make them consistent would be fine.
from typescript.
Yeah I wasn't sure what the "correct" behaviour should be and I don't think there's a right answer either.
The thing I think that is missing right now is that the order of declarations matters for TS to do its strike through.
I think it'll be worth linting and enforcing against the ambiguity in DefinitelyTyped. I'll raise an issue over there.
from typescript.
Related Issues (20)
- GitHub Issue Duplicate Detector HOT 2
- Template literal type derived from string is not a subtype of the TLT derived from any
- Improve Iterator Helper Type Signatures HOT 10
- Missing Handbook Content HOT 3
- Suggest @ts-expect-error as Quick Fix
- @import suggestions for auto-imports in VS Code
- Binding element incorrectly reported as having `any` type in JS with JSDoc starting with 5.6.2 HOT 3
- React's ComponentProps type issues in TypeScript 5.6.2 HOT 11
- The function type should not inherit the built-in object type HOT 3
- Ability for compiler host to provide resolution mode for file and say it supports impledNodeFormat HOT 2
- Generated d.ts imports package that is not installed on current project HOT 2
- Organize imports preferences don't seem to work
- Types as Values (Symbols?) HOT 2
- Narrow types with boolean literal discriminants HOT 2
- Fail to infer Indexed access to the intersection type when it includes an union derived from a generic input HOT 1
- Generators can return undefined values HOT 1
- Inconsistent behaviour of `-?` HOT 4
- Function parameter type inference error HOT 4
- FETCH / Give The json() Function The Power To Use Generic Type HOT 1
- TS 5.6 requires composite projects with noEmit to have fully accessible types, unlike 5.5 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.