Giter VIP home page Giter VIP logo

Comments (2)

RyanCavanaugh avatar RyanCavanaugh commented on September 27, 2024 2

I would love to see some clarification on what you guys think is the correct behaviour so that we can follow-suit!

I have no idea and I don't think it's likely that a poll of developers would produce a strong majority outcome either. It seems much more clarifying to either write

/** @deprecated */
namespace Foo1 {
  export namespace Bar {
    export const x = 1;
  }
}

or

namespace Foo1 {
  /** @deprecated */
  export namespace Bar {
    export const x = 1;
  }
}

depending on which is intended (hopefully they both work more consistently?)

A PR to make them consistent would be fine.

from typescript.

bradzacher avatar bradzacher commented on September 27, 2024

Yeah I wasn't sure what the "correct" behaviour should be and I don't think there's a right answer either.

The thing I think that is missing right now is that the order of declarations matters for TS to do its strike through.

I think it'll be worth linting and enforcing against the ambiguity in DefinitelyTyped. I'll raise an issue over there.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.