Find all references in TS is off by 1 line in this specific case about typescript HOT 4 OPEN

Ah, I rewatched the video and see what you mean.

from typescript.

It looks like you requested find-all-references while the full language service is not loaded. Specifically, there's two processes - a partial server and a full server. The partial server tries its best to answer questions based on open files. Please let me know if I've missed something.

from typescript.

It looks like you requested find-all-references while the full language service is not loaded. Specifically, there's two processes - a partial server and a full server. The partial server tries its best to answer questions based on open files.

Yes, I tend to run a lot into the single-file server giving bad results for find references. I see how it's useful to give the illusion of speed, and it's a cool idea with it serving syntax based requests, etc. Do you know if there are some settings to opt out of it for the find references? I never invoke find references on a non-exported symbol, I always use F7 to loop through references if I want to go to usages in the current file. I only use find all references when I want to find usages in other files, so I would much prefer a "Loading..." experience where it eventually gives the correct results instead of the current local references which forces me to refresh or retrigger. I think I had a dicussion about this with @mjbvz or @jrieken in the past but they said that there is no API / event to refresh the result list once the real server kicks in, so that would turn into an api discussion.

from typescript.

so I would much prefer a "Loading..." experience where it eventually gives the correct results instead of the current local references which forces me to refresh or retrigger.

I do agree and I think the current behaviour is wrong. Find all references should always yield the same result independent of where the extension is in its startup phase.

Also correct that streaming is an ask but that is quite far out because UI stability will be an issue (when/how do you resort the result). Wrt to the API it might just be about returning an iterable over an array

from typescript.