Comments (6)
Now that I've started to work with TSLint I'm starting to feel the same, that is I'd like to see whether are warning comes from TypeScript or TSLint.
@dbaeumer I suggest we come up with a guideline and then apply it across all the linters.
My preference would be to show the linter/source at the end of the message, i.e.,
You have done something stupid (stupid-syntax-rule) [ESLint]
The message is the 'main' thing and it should come first before the linter which is secondary information.
from vscode-eslint.
@egamma - I agree.
from vscode-eslint.
I think we should not mangle this (from an API perspective) into the message. Instead we should enhance the Diagnostic API with a source field and allow linters to fill in that field. This would allow for proper filtering and grouping in the UI side. See microsoft/vscode#1010 for the discussion on the VS Code side.
from vscode-eslint.
I was only taking about the rendering.. Fully agree, that this should not be done with string concatenation, but an API.
from vscode-eslint.
This got addressed a long time ago.
from vscode-eslint.
Got fixed a long time ago.
from vscode-eslint.
Related Issues (20)
- Feature request: show notification when ESLint fails to load HOT 5
- Use a new client on restart server if the previous start has failed HOT 2
- Feature request: bring back enable/disable eslint command HOT 1
- Extension can't find typescript-eslint parser with yarn's pnpm linker installation layout HOT 3
- ESLint Not Showing Inline Error Hints for .wxml Files in VS Code HOT 1
- Feature request: Provide a way to control files fixed during onCodeActionsSave (e.g., ignorePatterns) HOT 5
- Errors differ from command line for import ordering HOT 1
- Eslint does not reload dependencies after installing a new package ('X' should be listed in the project's dependencies) HOT 1
- Eslint server could not found config file. HOT 10
- "Unknown options: extensions" error using flat config HOT 28
- 'Incorrect Type. Expected "object"' Error When Specifying an ESLint Rule String Option HOT 1
- imports do not work in flat config yarn pnp HOT 5
- ESLint config not found for flat config HOT 6
- [feat] `eslint.lintTask.command: string`
- Parsing error: __classPrivateFieldGet(...).at is not a function | After upgrading to newest version of Typescript & Eslint HOT 3
- Update default options for `eslint.probe` to include json, jsonc HOT 1
- Local config seems to be ignored :shrug: HOT 3
- eslint is not loading suddenly HOT 1
- Sorting is bugged HOT 2
- Full support for esm flat configs HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-eslint.