Giter VIP home page Giter VIP logo

Comments (6)

egamma avatar egamma commented on July 17, 2024

Now that I've started to work with TSLint I'm starting to feel the same, that is I'd like to see whether are warning comes from TypeScript or TSLint.

@dbaeumer I suggest we come up with a guideline and then apply it across all the linters.

My preference would be to show the linter/source at the end of the message, i.e.,

You have done something stupid (stupid-syntax-rule) [ESLint]

The message is the 'main' thing and it should come first before the linter which is secondary information.

from vscode-eslint.

LittleBrainz avatar LittleBrainz commented on July 17, 2024

@egamma - I agree.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

I think we should not mangle this (from an API perspective) into the message. Instead we should enhance the Diagnostic API with a source field and allow linters to fill in that field. This would allow for proper filtering and grouping in the UI side. See microsoft/vscode#1010 for the discussion on the VS Code side.

from vscode-eslint.

egamma avatar egamma commented on July 17, 2024

I was only taking about the rendering.. Fully agree, that this should not be done with string concatenation, but an API.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

This got addressed a long time ago.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

Got fixed a long time ago.

from vscode-eslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.