Giter VIP home page Giter VIP logo

Comments (9)

hogart avatar hogart commented on July 17, 2024

Not sure what's the difference, but jscs extension works properly with similar setup on the same project.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

Could reproduce. Need to understand why this is the case since we delegate config reading to the eslint node module.

from vscode-eslint.

hogart avatar hogart commented on July 17, 2024

I've found something. You can repeat my steps by setting breakpoint on line 122 of server.ts.

cli.executeOnText calls cli.getConfigForFile to determine which set of rules to apply (see eslint sources). cli.getConfigforFile('d:\some\path') return config object with empty fields. While cli.getConfigforFile('d:/some/path') (note backslashes) return correct config object. And vscode-languageserver.Files.uriToFilePath return path with backslashes \.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

@hogart: thanks a lot for the tip. Will have a look.

from vscode-eslint.

hogart avatar hogart commented on July 17, 2024

Actually I'm not sure this is vscode-eslint issue. Back-slashed (\) paths are officially returned from path.normalize, so every node software should know how to handle it. The question is should we raise it to eslint, or create workaround, or may be both? It still bothers me that standalone eslint . command works properly.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

I debugged it again and actually the config in package.json is honored. I used eslint version 1.10.3. The path uses backslashes and the actual resolving is happening from the package.json file.,

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

@hogart I tried to clone the repository from your first comment but it is not public. If you provide me access to the code or attach a zip with it I will investigate further.

from vscode-eslint.

hogart avatar hogart commented on July 17, 2024

Very strange, but I can't reproduce it now too.
Probably it was problem of some particular eslint version.

from vscode-eslint.

dbaeumer avatar dbaeumer commented on July 17, 2024

@hogart thanks. I will close the issue. Pls reopen if you see it again.

from vscode-eslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.