ESLint linter doesn't honor .eslintignore file about vscode-eslint HOT 16 CLOSED

I would like to see this bug fixed as well. Not being able to ignore 3rd party libraries, for example, is problematic.

from vscode-eslint.

@dbaeumer Open files are still being linted in VS Code 1.12.0 and ESLint extension 1.2.8

from vscode-eslint.

Same in Windows environment

from vscode-eslint.

@irowe the linting of files inside the node_modules folder was caused by a bug I introduced in 1.2.3. If fix this in 1.2.4.

from vscode-eslint.

Same issue here, too many error and warning message cause vscode can't work anymore (with node_modules in project folder)

EDIT:
On VSCode Insider 1.6 for Windows, with extension HTML CSS Class Completion

from vscode-eslint.

I tried to reproduce this and wasn't able to do so using a simple setup.

See the two screen shots.

Can some of you share your setup so that I can investigate why this isn't working for you.

from vscode-eslint.

@dbaeumer I have add node_modules to .eslintignore, but it still cause vscode stop response after install HTML CSS Class Completion and open a folder contain node_modules with a lot of npm package.

Or it can't match folder, only file?

from vscode-eslint.

@ArianeLu this looks like a different issue unrelated to eslint. Could you share your workspace so that we can investigate this?

from vscode-eslint.

I am closing this issue since I can't reproduce and @ArianeLu issue is different.

from vscode-eslint.

I have the same problem.
could you try with .eslintignore with **/*.js ? mac environment.

from vscode-eslint.

@sonnn do you have a workspace I can reproduce I could clone.

from vscode-eslint.

Just encountered this still.... in windows and using .eslintignore

// .eslintignore
dbin/*

still linting dbin/x.js

from vscode-eslint.

With or without an .eslintignore, I'm seeing eslint retporting problems for open javascript files within my node_modules (which should be ignored by default.) This is on a Mac with VS Code 1.9.0.

from vscode-eslint.

@cdierkens can you provide a workspace to reproduce. I can't not using my setup:

from vscode-eslint.

Sorry for the dig ...

@dbaeumer I have created a repo to reproduce the issue
This demo web-store project is combined by frontend and backend sub projects. The frontend is an webpack project created by vue-cli, the backend is an django project.

I have tried to config the ignorePath param in the workspace's settings.json as follows

{
  "eslint.options": {
    "ignorePath": "${workspaceRoot}/frontend/.eslintignore"
  }
}

But it seems that eslint-plugin can not read the eslintignore file and the ignored files are still linted?

BTW, if I move the .eslintignore file to the root directory, the eslint plugin can work as expect.

from vscode-eslint.

This requires a working directory setup since the .eslintignore file is read relative to the current working directory by eslint. See https://github.com/Microsoft/vscode-eslint#settings-options

from vscode-eslint.