Disable strict SSL in ./node_modules/vscode/bin/install script? about vscode-extension-vscode HOT 7 CLOSED

@emackey to verify the fix would work can you open the file node_modules/vscode/lib/shared.js in your extension folder and change the options bag to this:

var options = {
    url: url,
    strictSSL: false,
    headers: headers
};

And then run npm install again to see if this time it fetches the vscode.d.ts properly?

Looks like I could read out process.env.npm_config_strict_ssl: 'true' before the remote call and set strictSSL option according to that value.

from vscode-extension-vscode.

@bpasero Sure, I should be able to work it tonight.

from vscode-extension-vscode.

From @joaomoreno on March 6, 2017 10:46

@bpasero The code to fetch vscode.d.ts should maybe pay attention to npm's value of strict-ssl?

from vscode-extension-vscode.

@bpasero I can confirm that the options change fixes the problem for me. Thanks for taking this on!

from vscode-extension-vscode.

Fixed via 1.0.6

from vscode-extension-vscode.

@bpasero it seems that there is a bug in npm when setting environment variables based on config variables to false (see here). I think this issue still exists due to this fact and that I am still running into a similar issue:
Error installing vscode.d.ts: Error: unable to get local issuer certificate

This commit in particular seems to fix it by comparing the value to the "true" string and flipping the logic.

from vscode-extension-vscode.

@camwar11 good catch, want to jump in with a PR?

from vscode-extension-vscode.