Background of covered and not covered code cannot be removed after running package test about vscode-go HOT 9 CLOSED

@kegsay thanks for the pointer. I don't know why but I observed isDirty is never true when the callback is invoked. Can you please take a look at the linked PR?

@ramya-rao-a I sent my PR for the fix in golang/vscode-go. How do you want to handle PRs for minor bug fixes like this during the repo migration?

from vscode-go.

I had the same experience, @blocknonip. I thought I was going crazy for about an hour - went through restarting/reinstalling everything multiple times, modifying all the coverage-related settings...

I understand the motivation for this, and can see how maintaining the highlighting during typing is potentially helpful. But from my reading of the PR, I also assumed that the coverage info would disappear if the file was saved. Instead, for me, new text is highlighted in a grayer shade of green, and I can only turn it off with the menu > toggle.

from vscode-go.

Sorry about this folks and thanks for the pointer to the PR @hyangah

I consider this more than a minor bug, so I went ahead with the fix and have released an update (version 0.14.3). The code coverage should be cleared on file save now.

Thanks for reporting @xhit!

from vscode-go.

I would strongly support reverting this change. I thought my IDE was broken because changing code and saving would no longer remove the coverage highlighting, as it has for literally years prior.

If not, please give us a toggle to support the original behavior. I know I can bring up the menu and toggle test coverage (or set a keybinding, etc, etc), but that's a slew of new steps that weren't needed before.

from vscode-go.

I notice that issue #2551 is related and the PR #2853 is the root cause, so:

• There are options to returns back to previously behavior?
• Why maintain this background of covered code always even when new code is added and file edited?

from vscode-go.

@xhit does the coverage info still remain if the edited file is saved?
I believe the issue #2551 is a feature request to preserve the coverage info while typing because otherwise, it is difficult to fix code based on the coverage feedback.

from vscode-go.

does the coverage info still remain if the edited file is saved?

Yes.

from vscode-go.

Thanks. I could reproduce this as well.
@ramya-rao-a @kegsay Is this intended behavior?

from vscode-go.

One of the conditionals on https://github.com/microsoft/vscode-go/pull/2853/files#diff-44e85398a1742b4d78705053c4a98671R300 must be failing - there was a long period between me making that PR and asserting its behaviour and it ended up getting merged in, so it's possible something has changed in the intervening months which breaks the PR.

from vscode-go.