Diagnostic pulling could support multiple identifiers to allow for two stage diagnostic retrieval about vscode-languageserver-node HOT 7 CLOSED

Actually the idea is that additional pull providers are registered dynamically. So each registration can have its own identifier and set of attributes. Would that work for you?

from vscode-languageserver-node.

I must be doing the registration wrong then. I'm returning it in my server capabilities:

        if (this.client.hasPullDiagnosticsCapability) {
            result.capabilities.diagnosticProvider = {
                identifier: 'pylance',
                documentSelector: null,
                interFileDependencies: true,
                workspaceDiagnostics: initializationOptions.diagnosticMode === 'workspace',
            };
        }

Or are you saying there's a secondary step I can do after that to add more?

from vscode-languageserver-node.

I think this issue is a dupe of microsoft/language-server-protocol#1088, which I believe is asking for the same thing?

from vscode-languageserver-node.

Ah @heejaechang pointed out we could do it this way:
https://github.com/microsoft/pyrx/blob/main/packages/pyright/packages/pyright-internal/src/languageServerBase.ts#L1415

The spec says that each dynamic registration has to be a different document selector though.

Is that true?

from vscode-languageserver-node.

I think this issue is a dupe of microsoft/language-server-protocol#1088, which I believe is asking for the same thing?

That request was for the push diagnostics. It basically got added for pull with the identifier.

from vscode-languageserver-node.

Ah @heejaechang pointed out we could do it this way:
https://github.com/microsoft/pyrx/blob/main/packages/pyright/packages/pyright-internal/src/languageServerBase.ts#L1415

This is what I meant with dynamic registration.

Having two for the same selector for pull is fine since the identifier is part of the params. Otherwise you couldn't distinguish them. I will add something to the spec.

from vscode-languageserver-node.

Thanks, sounds like it will work then.

from vscode-languageserver-node.