Comments (7)
Actually the idea is that additional pull providers are registered dynamically. So each registration can have its own identifier and set of attributes. Would that work for you?
from vscode-languageserver-node.
I must be doing the registration wrong then. I'm returning it in my server capabilities:
if (this.client.hasPullDiagnosticsCapability) {
result.capabilities.diagnosticProvider = {
identifier: 'pylance',
documentSelector: null,
interFileDependencies: true,
workspaceDiagnostics: initializationOptions.diagnosticMode === 'workspace',
};
}
Or are you saying there's a secondary step I can do after that to add more?
from vscode-languageserver-node.
I think this issue is a dupe of microsoft/language-server-protocol#1088, which I believe is asking for the same thing?
from vscode-languageserver-node.
Ah @heejaechang pointed out we could do it this way:
https://github.com/microsoft/pyrx/blob/main/packages/pyright/packages/pyright-internal/src/languageServerBase.ts#L1415
The spec says that each dynamic registration has to be a different document selector though.
Is that true?
from vscode-languageserver-node.
I think this issue is a dupe of microsoft/language-server-protocol#1088, which I believe is asking for the same thing?
That request was for the push diagnostics. It basically got added for pull with the identifier.
from vscode-languageserver-node.
Ah @heejaechang pointed out we could do it this way:
https://github.com/microsoft/pyrx/blob/main/packages/pyright/packages/pyright-internal/src/languageServerBase.ts#L1415
This is what I meant with dynamic registration.
Having two for the same selector for pull is fine since the identifier is part of the params. Otherwise you couldn't distinguish them. I will add something to the spec.
from vscode-languageserver-node.
Thanks, sounds like it will work then.
from vscode-languageserver-node.
Related Issues (20)
- Fix CancellationReceiverStrategy type definition to include RequestCancellationReceiverStrategy HOT 1
- changelog?
- Expected sequence of events for an initialization failure HOT 2
- LanguageClient adds an extra `--stdio` argument when using `TransportKind.stdio` HOT 1
- Error compiling test-provider-sample executionCount does not exist on type StatementCoverage
- Kobicoin HOT 2
- LSP request failure toasts cannot be turned off HOT 9
- Missing `onSemanticTokens` method on `Connection` HOT 2
- Semantic tokens that are not in ascending order will not be highlighted HOT 7
- Document symbols in editor do not show after starting VSCode with file open HOT 8
- Two-part Hover info using `MarkupContent` HOT 3
- Language server is not started until a file is opened HOT 1
- Diagnostics pulling doesn't work for notebook cells HOT 4
- Missing 'export TypeHierarchyMiddleware' from api.ts
- Option to control `workspaceFolders` in `InitializeParams` HOT 1
- Incorrect handling of diagnostic pull request cancellation HOT 2
- Race condition in sendRequest in jsonrpc HOT 1
- Can you provide a monaco-editor demo HOT 2
- semanticTokensProvider is missing Connection implementation HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-languageserver-node.