Giter VIP home page Giter VIP logo

Comments (4)

benibenj avatar benibenj commented on September 8, 2024 1

I agree we should do something to make sure the user is aware of .vscodeignore. I think we should print a warning when we do not detect a .vscodeignore file. We could also request the user to confirm that he wants to proceed without .vscodeignore file, however I fear we would break some pipelines with that.

Also printing what is being packaged is a great idea as mentioned here #995 and we could even provide a command to just print what would be packaged if the user runs vsce package or vsce publish so the user can see it without actually having to package the extension.

from vscode-vsce.

isidorn avatar isidorn commented on September 8, 2024 1

Good ideas. I suggest to discuss with Joao in your next sync, since he also has thoughts on this topic.

from vscode-vsce.

benibenj avatar benibenj commented on September 8, 2024

Building on the work completed in #995, we have added a warning for users who are not using either a .vscodeignore file or the "files" property in package.json. Additionally, we have made several minor enhancements to improve the overall experience for users packaging their extensions. These changes aim to ensure that extensions are packaged as expected.

from vscode-vsce.

isidorn avatar isidorn commented on September 8, 2024

Works great -> verified
For a missing license file we ask the user to confirm with a Y. But for a missing .vscodeignore we just print a warning, and do not prompt the user. Should we prompt?

Image

from vscode-vsce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.