Warn if types from Microsoft.VisualStudio.Shell.XX are exposed about vssdk-analyzers HOT 4 OPEN

@AArnott they are supposed to already be internal, but we'd fix any that were found.

from vssdk-analyzers.

I'm actually thinking we should Won't Fix this. @sharwell, how can we flag when assemblies expose MPF types in their public API when it's by design that they should do so? For example, a public type will derive from Package. In fact many MPF types may be exposed in "public" API for testability purposes (yes InternalsVisibleTo could be used, but that can be an MPF interop problem too, as we've seen with Roslyn).

from vssdk-analyzers.

For example, a public type will derive from Package.

There are two resolutions for this:

1. The safest resolution is to mark the type which derives from Package as internal instead of public.
2. An alternative solution, typically for cases where the developer knows there are no other assemblies depending on a project, is to simply disable the rule.

from vssdk-analyzers.

@sharwell Would your team mark all the relevant types internal or would you turn the rule off?

from vssdk-analyzers.