Giter VIP home page Giter VIP logo

Comments (12)

OriHoch avatar OriHoch commented on August 10, 2024

@amotenko - I'm already working on it.. will publish a pull request soon
re-assigning back to me..

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

in #45 I added notification to slack on every build of master

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

continuing to work on it with the staging server

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

basic auto deploy is working on staging, relevant documentation:
https://github.com/Midburn/Spark/blob/master/docs/development/devops.md

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

@amotenko - why did you close it?

from spark.

amotenko avatar amotenko commented on August 10, 2024

if I'm not mistaken we got everything , but correct me if I'm wrong

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

I didn't open this issue but AFAIK some points from original description are not done yet:
[] Add all spark devs to sparksystem-alerts (if anyone wants to leave they can)
[] Add #sparksystem-alerts as a default channel for new devs on Slack
[] Nice to have: if you personally broke the build, you get a pm.

we have some limited integration, but I'm not sure what was the original intent

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

I usually let the original reporter (in this case @ripper234) close the issue or at least give him a chance to respons before closing to make sure no idea is left behind..

also, explaining why issue is closed is required in my opinion for correct working flow

from spark.

ripper234 avatar ripper234 commented on August 10, 2024

Thanks @OriHoch.
@amotenko : I agree that in general when closing, an explanation should be mandatory.

However in this case I'm not really a part of the workflow these days, so I have no objection to closing if @amotenko wants. Closing it for now.

from spark.

amotenko avatar amotenko commented on August 10, 2024

@ripper234 , @OriHoch I know it sounds retarded but I wasn't aware of this aspect of open source project etiquette, so thank you for pointing this out.
Regarding the bullets above, I may be biased and please tell me if you feel that's wrong but I think that 'noise' should always be opt-in and not opt-out, especially for newcomers.
Regarding the last bullet, today with Travis we can't push a branch if it's breaking a build, so is this scenario possible?

from spark.

ArtyomKa avatar ArtyomKa commented on August 10, 2024

from spark.

OriHoch avatar OriHoch commented on August 10, 2024

@ArtyomKa - spark's travis runs on pull requests so you don't have to configure travis for each fork
you just have to open a pull request and mark it as in progress so it won't be merged..

from spark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.