Calendar and Tag templates should use articles, not page_articles about middleman-blog HOT 6 CLOSED

Interesting - page_articles should be a paginated subset of the articles for that year/tag, not the whole list. @rumpuslabs, care to comment?

from middleman-blog.

We iterate over page_articles to allow the template to be used for both paginated and unpaginated blogs. When blog.paginate is not set, setting page_num in the template frontmatter will limit page_articles to the last n articles, equivalent to the old articles[0...10] construct. If blog.paginate is false and page_num is not set in the template frontmatter, page_articles will be equal to articles. This is the default if blog.paginate is not set in config.rb.

from middleman-blog.

I was playing with the default templates, which have pageable: true at the top, but I have blog.paginate set to false in my config. I haven't set page_num anywhere.

With those settings I am seeing articles be the correct subset (for the tag or year) but page_articles be an unfiltered list of all the blog articles.

I'm using middleman-blog-3.1.0 and middleman-3.0.4.

from middleman-blog.

(Please forgive my ignorance and general bumbling, I just started looking at the code last night.)

It looks like in extension.rb, Middleman::Blog::Helpers::page_articles is defined and directly references blog.articles. I wonder if this should be referring to something like current_resource.metadata[:locals]["articles"] instead? Otherwise it ignores the filtering set in tag_pages.rb and calendar_pages.rb.

from middleman-blog.

You're absolutely right. Working on a fix now.

from middleman-blog.

middleman-blog 3.1.1 is out, and includes this fix.

from middleman-blog.