Giter VIP home page Giter VIP logo

Comments (2)

miekg avatar miekg commented on August 24, 2024

[ Quoting [email protected] in "[dns] No RDATA records in text form..." ]

RData length will be 0 and there would be text representation like this:

example.org. 0 ANY A

This library correctly represents such text representation from something like this:

&dns.A{
Hdr: dns.RR_Header{
Name: "example.org.",
Rrtype: dns.TypeA,
Class: dns.ClassANY,
Ttl: 0,
Rdlength: 0,
},
A: nil,
}.String()

but fails to parse it back into RR, this one will panic regardless of whitespace after A:

_, err := dns.NewRR("example.org. ANY A")
if err != nil { panic("got error") }

This would not affect much real world operations! I don't know where the need of parsing such records in text format would arise but IMO it worth discussion if this behavior should be considered a bug.

I did not check much but Net::DNS is installed and seem to read those properly:

$ perl -Mv5.16 -MNet::DNS -e "say Net::DNS::RR->new('example.org. ANY A')->string();"
example.org. 0 ANY A ; no data

Yes, this is a bug and an annoying one as well, because it effects the parsing
and the packing/unpacking functions -- although packing/unpacking should be
fine-ish.

/Miek

Miek Gieben

from dns.

miekg avatar miekg commented on August 24, 2024

[ Quoting [email protected] in "[dns] No RDATA records in text form..." ]

_, err := dns.NewRR("example.org. ANY A")
if err != nil { panic("got error") }

This would not affect much real world operations! I don't know where the need of parsing such records in text format would arise but IMO it worth discussion if this behavior should be considered a bug.

I did not check much but Net::DNS is installed and seem to read those properly:

$ perl -Mv5.16 -MNet::DNS -e "say Net::DNS::RR->new('example.org. ANY A')->string();"
example.org. 0 ANY A ; no data

Added TestDynamicUpdateParsing as a test and fixed some records, but more work
is needed.

/Miek

Miek Gieben

from dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.