MsgHdr.Rdlength is not set by NewRR about dns HOT 6 CLOSED

This is sort of by design, because when the string is parsed you do not know how long the rdata will be. This value is set when the data is converted to wireformat.

It might make sense to rename Rdlength to rdlength. I any case this could use some extra documentation.

from dns.

Closed by b047415

from dns.

Hmm... what would you recommend for comparison, then? Is comparing the rr.String()s sufficient for testing that my code isn't doing anything stupid?

/is really annoyed that reflect.DeepEqual looks at private fields.

from dns.

For those comparisons you should not look at Rdlength. Converting to
strings and then comparing seems suboptimal.
On Apr 21, 2014 4:25 PM, "Philip Horger" [email protected] wrote:

Hmm... what would you recommend for comparison, then? Is comparing the
rr.String()s sufficient for testing that my code isn't doing anything
stupid?

/is really annoyed that reflect.DeepEqual looks at private fields.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/91#issuecomment-40943698
.

from dns.

So, all the components of the header are significant, except rdlength?

Sorry, I know I'm being a pest, and this information is really helpful. I'm just trying to figure out exactly what I need to test, and what I need to ignore.

from dns.

On Apr 21, 2014 4:47 PM, "Philip Horger" [email protected] wrote:

So, all the components of the header are significant, except rdlength?

Yes, unless its not zero :)

Sorry, I know I'm being a pest, and this information is really helpful.
I'm just trying to figure out exactly what I need to test, and what I need
to ignore.

—
Reply to this email directly or view it on GitHub.

from dns.