Giter VIP home page Giter VIP logo

Comments (14)

mifi avatar mifi commented on May 16, 2024 3

Yes, we could keep the already rendered waveform. I can make that change.

from lossless-cut.

mifi avatar mifi commented on May 16, 2024 2

Waveform and thumbnails is now implemented

from lossless-cut.

opusforlife2 avatar opusforlife2 commented on May 16, 2024 2

Taller, definitely, like 6-7 times the current height. Something like the size Audacity shows, so that it is easy to comprehend and use.

Expandable is up to you.

from lossless-cut.

WiliTest avatar WiliTest commented on May 16, 2024 1

I wish I could use it to quickly trim audio, but the waveform is too small/basic. Would it be possible to add a real waveform, just for audio files (it's needed to find the right spot on long audio files)?

from lossless-cut.

opusforlife2 avatar opusforlife2 commented on May 16, 2024 1

I agree. With audio files, the entire space kept for video is wasted real estate. The audio waveform could be much bigger and easier to see.

Also, the waveform only shows up for part of the file. If you jump to another frame, the audio waveform gets extended further, but the beginning portion gets cut off. Is it a limitation that the entire waveform cannot be shown at once? One would think since it's a static property of a file, it could be loaded fully just once and that's it.

from lossless-cut.

mifi avatar mifi commented on May 16, 2024

It should be possible but I can imagine that it would require preprocessing in order to create thumbnails/waveform, and this will probably take some time, defeating the purpose of this being a very fast app.

from lossless-cut.

TechManiacHD avatar TechManiacHD commented on May 16, 2024

Would be nice to have but not that essential INHO. Program is currently blazing fast so adding this future might hurt it.

from lossless-cut.

opusforlife2 avatar opusforlife2 commented on May 16, 2024

https://trac.ffmpeg.org/wiki/Waveform

@mifi Have you looked at this filter? It's a part of ffmpeg.

from lossless-cut.

mifi avatar mifi commented on May 16, 2024

Also this: https://github.com/katspaugh/wavesurfer.js

from lossless-cut.

mifi avatar mifi commented on May 16, 2024

It's a technical limitation because rendering the waveform takes a long time. So it will only render 30 seconds at a time. I'm not sure what is the best way to render a zoomed out waveform overview for the whole clip. See #260

from lossless-cut.

opusforlife2 avatar opusforlife2 commented on May 16, 2024

I'm not sure I get this. Rendering 30 seconds at a time shouldn't prevent you from still displaying the already rendered waveform. It's fine if a 2 minute song renders in 4 sections. Or is the problem something else?

from lossless-cut.

opusforlife2 avatar opusforlife2 commented on May 16, 2024

With audio files, the entire space kept for video is wasted real estate. The audio waveform could be much bigger and easier to see.

And what is your opinion on this?

from lossless-cut.

mifi avatar mifi commented on May 16, 2024

And what is your opinion on this?

You mean you want it to be taller or expandable? That shouldn't be too hard

from lossless-cut.

mifi avatar mifi commented on May 16, 2024

Closing in favor of #260

from lossless-cut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.