Giter VIP home page Giter VIP logo

Comments (6)

alexlafroscia avatar alexlafroscia commented on May 12, 2024

Do you have an example of what you'd like this to look like instead? I would love to help fix this.

from ember-paper.

miguelcobain avatar miguelcobain commented on May 12, 2024

The main problem is here: https://github.com/miguelcobain/ember-paper/blob/master/app/templates/components/paper-nav-container.hbs#L2

When the sidenav is closed, open is set to false and the backdrop is immediately removed from DOM. We need to give some time for the backdrop to fade out before removing it.

Two solutions came to mind:

  • Perhaps using a transitionEnd event or something.
  • Maybe the backdrop could always stay there but we get it "out of the way" with some styling trick
    Not really sure the best way to do this. :/

The angular material website is an example of a correct fade out animation: https://material.angularjs.org/
(don't forget to enter the open/close mode by resizing the viewport)

from ember-paper.

alexlafroscia avatar alexlafroscia commented on May 12, 2024

Alright cool, I'm coming up on Spring Break next week and will see if I can get a PR together for this 😄

from ember-paper.

alexlafroscia avatar alexlafroscia commented on May 12, 2024

I'm reading through the code and trying to understand it. What does the backdrop do? And where is the resizing of the browser listened for?

from ember-paper.

miguelcobain avatar miguelcobain commented on May 12, 2024

Backdrop is the dark transparent element that covers the content when the sidenav is open (in open/close mode).
The resizing behaviour is entirely defined using css media queries.

from ember-paper.

alexlafroscia avatar alexlafroscia commented on May 12, 2024

Oh, I see. Thanks!

from ember-paper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.