Giter VIP home page Giter VIP logo

Comments (3)

Merenptah avatar Merenptah commented on May 27, 2024 1

Hi Michi,

Looks pretty nice.
Some notes:

  • dependsOn: For consistency mayDependOn
  • There doesn't seem to be any difference between Layer and Component and Package, you intend to add syntactic sugar for all these more or less equivalent notions?

Do you know how you will handle the errors? Since it does not make much sense to define a test for each layer restriction it would be great if all errors in one test are collected and returned in one report.

Best
Hannes

from dephpend.

mihaeu avatar mihaeu commented on May 27, 2024

Thanks for the feedback @Merenptah

I finally got around to actually implement a first draft. Super ugly, but it's a start. Test cases aren't looking too bad: https://github.com/mihaeu/dephpend-tests/blob/master/tests/integration/ArchitectureTest.php

dependsOn: For consistency mayDependOn

+1

There doesn't seem to be any difference between Layer and Component and Package, you intend to add syntactic sugar for all these more or less equivalent notions?

Good question. I was thinking syntactic sugar doesn't hurt, on the other hand people complain when you remove it later on ... hmmm.

Do you know how you will handle the errors? Since it does not make much sense to define a test for each layer restriction it would be great if all errors in one test are collected and returned in one report.

Definitely. I was thinking of:

  • may depend on
  • nothing else
  • may not depend on
  • may not depend on anything

That would be for outgoing dependencies. Not sure yet what to do about incoming dependencies.

I added a basic MVC example at https://github.com/mihaeu/dephpend-tests with one violation. Implementation is a work in progress.

test
Generated using dephpend uml tests/examples/mvc --output=test.png

Test output should be something like:

  • Class XYZ from (layer|module|component|package) ABC should not depend on Class IOP from (...) JKL

from dephpend.

mihaeu avatar mihaeu commented on May 27, 2024

I will stop using issues for my personal feature requests because it makes the project look more broken than it is 😅

from dephpend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.