middleware: Replace .onWrite method with the ability to return a different writable stream about tako HOT 5 OPEN

i'd rather rip all the middleware out.

we should just implement JSON support inline, it already requires specifial hooks outside of the "middleware" stuff.

from tako.

Hm. Yeah, I guess you can just do exactly the same thing by listening to app.on("request", myMiddlewareBits).

That still doesn't make it possible to attach filters, though. I suppose you could probably do something like this:

var s = req.socket
var f = zlib.Unzip()
s.pipe(f)
req.socket = f

var s = res.socket
var f = zlib.Gzip()
f.pipe(s)
res.socket = f

but that's of course getting super overly familiar with implementation internals.

from tako.

yup, the only thing the framework needs hooks for are conditions that will require IO to complete and might need to be required for a route.

auth is one, sessions are another. I want to change the way auth is implemented in to a more generic "condition" system we can use for sessions and other things.

from tako.

But, no, you could still do json support as a purely external middleware thing if you could attach filters. Just define a stream filter that takes in Objects and spits out JSON, and another that takes JSON and spits out objects. The only other part is setting the content-type and accept headers appropriately.

from tako.

Hi!

I've implemented a gzip-middleware for tako https://github.com/kesla/tako-gzip. The suggested code that @isaacs wrote earlier doesn't work, since that gzips the headers also.
Instead I overwrote the _work and _end-methods in the response...
Heavily dependent on implementation internails...

from tako.