Allow promisifying methods (not just functions) about es6-promisify HOT 10 CLOSED

You should be able to pass a thisArg as the parameter to promisify. e.g. promisify(o.method, o);

from es6-promisify.

I know, this is what I meant by "binds the receiver explicitly". Whenever you use the function returned by promisify, this will always be o inside the method.

What I'm doing is something like this:

MyClass.prototype.method_promise = promisify_unbound(MyClass.prototype.method)
...
instance1.method_promise(...) // this = instance1 inside the method
instance2.method_promise(...) // this = instance2 inside the method

from es6-promisify.

Ah, I see. Do you think this is a good use case for a promisify library? Would it not be simpler to just return a promise?

from es6-promisify.

I meant to use it on methods that belong to libraries, which I did not write. Seems like a pretty good use case to me. (So MyClass is a bad name -- it should be LibraryClass.)

from es6-promisify.

I'm unconvinced of the use case for this. If you're modifying the prototype of a library, I'm not sure why you wouldn't do something like:

LibraryClass.prototype.method_promise = function (...args) {
    return new Promise((resolve, reject) => {
        args.push((err, data) => {
            if (err) {
                return reject(err);
            }
            resolve(data);
        });
        this.method(...args);
    });
};

or even:

LibraryClass.prototype.method_promise = function (...args) {
    if (!this._method_promise) {
        this._method_promise = promisify(this.method, this);
    }
    return this._method_promise(...args);
};

But if you want to submit a PR, I'd be happy to merge it :)

from es6-promisify.

By the same token, you can always promisify a regular function by doing:

fun promisified(...args) {
    return new Promise(function (resolve, reject) {
    libFunction(...args, function(err, data) {
             if (err == undefined) resolve(data)
             else reject(err)
        })
    })
}

Isn't the whole point of the library to do this as a one-liner,
and by the same token, shouldn't it also be a one-liner for methods?

from es6-promisify.

As I say, if you want to submit a good PR I'd be happy to merge it in.

from es6-promisify.

I'll do it.

A question regarding the interface however: my preference would be to drop the support for binding (the promisify(o.method, o) syntax). The unbinding way is more general and if you want binding it's very easy:

promisify(o.method).bind(o)
// or equivalently
promisify(o.method.bind(o))

Is that okay?

from es6-promisify.

@norswap I think you can just do promisify(o.method).bind(o)

from es6-promisify.

https://github.com/digitaldesignlabs/es6-promisify/blob/7eb2f5e9ae858742d495978efebafaee6719da97/lib/promisify.js#L40

Change this line to
let target = this;

This must solve problem.

from es6-promisify.