Comments (7)
No problem I didn't spend too much time. Yes, I'd be interested in helping out with a paper effort. My latest interest in the package is the wrapper to NLDI so maybe that's an area where I could contribute a use case..
from hydrodata.
Hi,
Yes, after a fantastic code review of AOI by @dblodgett-usgs I refined some function names and scope and haven't got around to fixing the packages relying on it. It is on my to-do list and I would welcome any contribution given your great R talents,
Mike
from hydrodata.
Sooo... I am super embarrassed now ... I fixed most of these issues and never pushed to GitHub 🤦 The code could still use a good amount of work/review and I hope to eventually write it up as a publication (maybe EMS) with some compelling use cases. Would you be interested in pushing it in that direction as a collaboration?
I will get that push up tonight/tomorrow morning...
Again, I feel so bad and hope you didn't spend to much time on this!
from hydrodata.
Just lurking here -- @ldecicco-USGS and I talked about moving an NLDI wrapper client from nhdplusTools out to dataRetrieval. Maybe a little collaboration to make sure it's good for all the use cases we have would be in order...
from hydrodata.
@dblodgett-usgs yeah what you raise is part of the larger point where I stopped focusing on this package - with the intention of coming back... The idea of a single data aggregator was getting to be heavy on maintenance and better things were being done in packages like nhdplusTools
. Mostly I was waiting for dust to settle :)
That said, perhaps part of our next talk can be figuring out where nhd "discovery" tools belong. Some really useful ones sit in nhdplusTools
, here, and in nwmHistoric
. Knowing where they go and consolidating them would be great!
The one aspect I like about this wrapper is that it builds out many NLDI requests and returns a list of spatial (sf) objects. I also like the generalization (in a naive sense) of the feature types (e.g. just the USGS siteID rather then "USGS-#")
from hydrodata.
In process on this. But I'm stumped on AOI::aoiProj
. What does that command map to in the current version?
from hydrodata.
That was a naive (bad) way of storing EPSG 4326 with the corresponding proj4 string. I think they should all be replaceable by 4326.
Thanks!
from hydrodata.
Related Issues (20)
- Vignettes HOT 1
- add HydroDate class to each function HOT 1
- add return_what call to all applicable functions HOT 2
- Add save as csv to save function
- Add improved naming convention to explore and inspect using define_clip_unit/name_clip_unit HOT 1
- New MET data sources HOT 5
- add checks to avoid re-download of existing objects HOT 1
- set up pkgdown site
- Integrate with RCC-ACIS HOT 1
- move towards httr, progress, crayon outputs
- Typos in HydroData:::col_lc HOT 3
- Find WBD fails on large queries HOT 2
- findWBD breaks topology HOT 1
- coveralls setup HOT 7
- Can't seem to get it downloaded HOT 1
- Implement starter vignette and link to rawgit view of it in readme HOT 2
- Create issues for planning implementation of test coverage HOT 2
- Does HydroData actually use sf package? HOT 2
- Get travis working with sf and bring back in DESCRIPTION HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hydrodata.