Able to pass props to buttons about react-multiline-clamping HOT 2 CLOSED

Hey, this looks fantastic! Looking forward to trying it out :)

I'll close this issue, since it's much better handled by the PR you referenced.

Thanks again for the great tool.

from react-multiline-clamping.

Hey Willow!

Love to hear that you found this little library useful :)

I was thinking on what you said and your solution looks great for what you are trying to archieve.

However I think we could maybe invert the show more/less buttons render responsability to the library consumer and that would be much more flexible, allowing more use cases not only passing custom props, classes etc but even entire custom components or maybe another elements and not only buttons.

There was another issue opened that asked about passing another elements instead of buttons and I think we could use this approach to cover both cases.

Take a look to this PR and let me know what you think and if you think it suites your use case :)

#19

With this new API you could do something like this:

 <Clamp
    withToggle
    showMoreElement={({ toggle }) => (
        <button type="button" onClick={toggle} className="button-primary">
            Show more
        </button>
    )}
    showLessElement={({ toggle }) => (
        <button type="button" onClick={toggle} className="button-primary">
            Show less
        </span>
    )}
>
    <p>{text}</p>
</Clamp>

And thanks again for your kind words and interest on contributing.

from react-multiline-clamping.