Test that SimScorer.computeSlopFactor doesn't increase as the distance goes up [LUCENE-8013] about stargazers-migration-test HOT 2 CLOSED

+1, the test would be simple.

at the same time maybe we should reconsider this method: it is strange the phrase "fuzziness" is allowed here, but term fuzziness is not for example. We could just use 1/(N+1) in SloppyPhraseQuery and that's the end of it. BooleanSimilarity will still score the same way, since it returns 1 for score(adjustedFreq), so we don't have evidence for any use-case for an alternate implementation?

I feel similar about scorePayload. If you want to score payloads, you must pass PayloadFunction logic to the payload-based query and write a custom similarity. So you have to split your custom logic across two places and the apis seem awkward because of that. So maybe additionally the scorePayload should be moved to PayloadFunction api so that its all in one place? Seems like we can potentially make it much better that way.

[Legacy Jira: Robert Muir (@rmuir) on Oct 25 2017]

from stargazers-migration-test.

So you have to split your custom logic across two places and the apis seem awkward because of that.

Agreed, it always felt awkward to me too.

+1 to get rid of compuleSlopFactor and computePayloadFactor

[Legacy Jira: Adrien Grand (@jpountz) on Oct 26 2017]

from stargazers-migration-test.