Remove unnecessary norms.advanceExact check in score() [LUCENE-8024] about stargazers-migration-test HOT 4 CLOSED

It looks dumb to fix this but its hard to reason about 3 cases when only 2 really exist (norms are omitted or you have a value >= 1 for the doc). This can make it more clear there isn't divide by zero issues and other problems related to the norm. Zero length is an impossible value, its either missing (which you can detect up-front for the entire segment), or its a positive value.

[Legacy Jira: Robert Muir (@rmuir) on Oct 31 2017]

from stargazers-migration-test.

Patching changing these cases to:

boolean found = norms.advanceExact(doc);
assert found;
norm = doSomethingWith(norms.longValue());

[Legacy Jira: Robert Muir (@rmuir) on Oct 31 2017]

from stargazers-migration-test.

+1

[Legacy Jira: Adrien Grand (@jpountz) on Oct 31 2017]

from stargazers-migration-test.

Commit 42c49c25d6b790bfea7f26e667013b865af74664 in lucene-solr's branch refs/heads/master from @rmuir
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=42c49c2

LUCENE-8024: Remove unnecessary norms.advanceExact check in score()

[Legacy Jira: ASF subversion and git services on Oct 31 2017]

from stargazers-migration-test.