Comments (7)
mikemccand
commented on June 12, 2024
Looking further, I think the FieldInfos.Builder behaviour is correct, as it's used by SegmentMerger and ReadersAndUpdates, where deletes and DV updates are flattened out. So this is really a bug in ParallelReader.
[Legacy Jira: Alan Woodward (@romseygeek) on Nov 09 2017]
from stargazers-migration-test.
mikemccand
commented on June 12, 2024
Thinking about this more, ParallelReader is really set up as an alternative to updatedDocValues, so maybe the simplest thing here is to disallow them completely? Check in the constructor if the incoming FieldInfo has a dvGen > -1, and throw an exception if so.
[Legacy Jira: Alan Woodward (@romseygeek) on Nov 09 2017]
from stargazers-migration-test.
mikemccand
commented on June 12, 2024
Turns out that it wasn't difficult to make ParallelLeafReader.getFieldInfos() return the right thing, and dv updates do seem to work correctly otherwise. Here's a patch fixing things.
[Legacy Jira: Alan Woodward (@romseygeek) on Nov 09 2017]
from stargazers-migration-test.
mikemccand
commented on June 12, 2024
Commit c0ed9199fae03142b4fe6adebdccec728158eb5b in lucene-solr's branch refs/heads/branch_7x from @romseygeek
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c0ed919
LUCENE-8045: ParallelLeafReader should correctly report FieldInfo.dvGen
[Legacy Jira: ASF subversion and git services on Nov 09 2017]
from stargazers-migration-test.
mikemccand
commented on June 12, 2024
Commit f0fec1fc5f037ed18c901e43f1d17c4e6594f152 in lucene-solr's branch refs/heads/branch_7x from @romseygeek
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f0fec1f
Revert "LUCENE-8017: Don't use ParallelReader in tests"
This reverts commit ff4874f3d3ff6c307121a6a1f6d87a33d45a48a4.
LUCENE-8045 makes this unnecessary
[Legacy Jira: ASF subversion and git services on Nov 09 2017]
from stargazers-migration-test.
mikemccand
commented on June 12, 2024
Commit 77ea2110965a05e91cbd04257ccd394e1fd3fad3 in lucene-solr's branch refs/heads/master from @romseygeek
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77ea211
LUCENE-8045: ParallelLeafReader should correctly report FieldInfo.dvGen
[Legacy Jira: ASF subversion and git services on Nov 09 2017]
from stargazers-migration-test.
mikemccand
commented on June 12, 2024
Commit e827f17be59d6f505cd920756e3ce780d30e2eb2 in lucene-solr's branch refs/heads/master from @romseygeek
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e827f17
Revert "LUCENE-8017: Don't use ParallelReader in tests"
This reverts commit ff4874f3d3ff6c307121a6a1f6d87a33d45a48a4.
LUCENE-8045 makes this unnecessary
[Legacy Jira: ASF subversion and git services on Nov 09 2017]
from stargazers-migration-test.
Related Issues (20)
- Code Cleanup: Use entryset for map iteration wherever possible - part 2 possible. [LUCENE-8979] HOT 5
- Optimise SegmentTermsEnum.seekExact performance [LUCENE-8980] HOT 9
- Update javadocs to reflect experimental status of Kuromoji DictionaryBuilder [LUCENE-8981] HOT 3
- Make NativeUnixDirectory pure java now that direct IO is possible [LUCENE-8982] HOT 31
- PhraseWildcardQuery - new query to control and optimize wildcard expansions in phrase [LUCENE-8983] HOT 13
- SynonymGraphFilter cannot handle input stream with tokens filtered. [LUCENE-8985] HOT 12
- Add asf.yaml to our git repo [LUCENE-8986] HOT 7
- Move Lucene web site from svn to git [LUCENE-8987] HOT 58
- Maximal -- Minimum Based Early Termination For TopFieldCollector [LUCENE-8988]
- IndexSearcher Should Handle Rejection of Concurrent Task [LUCENE-8989] HOT 10
- IndexOrDocValuesQuery can take a bad decision for range queries if field has many values per document [LUCENE-8990] HOT 8
- disable java.util.HashMap assertions to avoid spurious vailures due to JDK-8205399 [LUCENE-8991] HOT 13
- Share minimum score across segments in concurrent search [LUCENE-8992] HOT 7
- Change Maven POM repository URLs to https [LUCENE-8993] HOT 15
- Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll(). [LUCENE-8994] HOT 5
- TopSuggestDocsCollector#collect should be able to signal rejection [LUCENE-8995] HOT 1
- Add type of triangle info to ShapeField encoding [LUCENE-8997] HOT 4
- OverviewImplTest.testIsOptimized reproducible failure [LUCENE-8998] HOT 5
- expectThrows doesn't play nicely with "assume" failures [LUCENE-8999] HOT 12
- Cannot resolve classes from org.apache.lucene.core plugin and others [LUCENE-9000] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stargazers-migration-test.