Calculating PI to x DP about bignumber.js HOT 2 CLOSED

Hello
I'm not looking to add a pi calculation function to the library at this point, but some visitors may find it useful.
I tried it out and it seems to work okay apart from the fact that the last digit is sometimes incorrect, e.g. with pi(1) and pi(100).
To avoid this the DECIMAL_PLACES value could be increased to say digits + 2 for the calculation and then sum could be round to digits before its return.
I am not clear why you are storing and setting all the config properties, surely it's only the DECIMAL_PLACES value that needs to be stored, set and then restored.
Also, it looks like you are using the Machin formula and there are others that are considerably faster, for example see http://beej.us/blog/data/pi-chudnovsky-gmp/.

from bignumber.js.

I was storing and restoring because in some of the testing I was changing
these and found that if you change the rounding scheme then it causes the
PI calculation to go into an infinite loop. I haven't fully checked as to
why yet, just wanted to see if it would of any interest wrt the library.
The last digit is being rounded and perhaps it should be truncated instead,
something I will need to think about a little. I will take a look at the
link, thanks.

On 16 September 2013 21:04, Michael Mclaughlin [email protected]:

Hello
I'm not looking to add a pi calculation function to the library at this
point, but some visitors may find it useful.
I tried it out and it seems to work okay apart from the fact that the last
digit is sometimes incorrect, e.g. with pi(1) and pi(100).
To avoid this the DECIMAL_PLACES value could be increased to say digits +
2 for the calculation and then sum could be round to digits before its
return.
I am not clear why you are storing and setting all the config properties,
surely it's only the DECIMAL_PLACES value that needs to be stored, set
and then restored.
It looks like you are using the Machin formula and there are others that
are considerably faster, for example see
http://beej.us/blog/data/pi-chudnovsky-gmp/.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-24535467
.

from bignumber.js.