Comments (6)
This was pretty confusing for me. If an expired or invalid token is not an exception, what is?
Here's the middleware I ended up with.
function authenticate() {
return (req, res, next) => {
passport.authenticate('jwt', (err, data, info) => {
if (err || info) {
next(new Error('Unauthorized.'));
} else {
next();
}
})(req, res, next);
};
}
from passport-jwt.
@LukeAskew I wrote this module using passport-local as a model.
In passport-local, which was written by the author of the passport framework, failure to authenticate is not treated as an exception. Instead, invalid credentials results in the strategy calling self.fail() (which populates info). I treat expired or invalid JWT's the same way the passport-local strategy would treat an incorrect password or a non-existent user.
Based on my understanding of passport-local, only things like database errors, etc. result in exceptions. To me this makes sense since exceptions should be reserved for unexpected errors. Invalid auth credentials are an expected case for an authentication framework and not treated as an exception by this module or passport-local.
from passport-jwt.
This issue makes this lib completely unusable for anything more advanced/custom than basic examples.
Nothing in the documentation explains how to actually handle each error case either.
It was a very frustrating experience getting to this specific issue on github, just to see that its not considered a thing.
from passport-jwt.
From the Custom Callback documentation:
If authentication failed, user will be set to false. If an exception occurred, err will be set. An optional info argument will be passed, containing additional details provided by the strategy's verify callback.
err should only be non-null when an exception occurs. Currently this library does not treat malformed JWT's or expired JWT's as exceptions, just failed authentication attempts.
While I could see the reasoning for treating a malformed JWT as an exception while maintaining the current behavior for expired JWT's I don't know that it would be worth breaking compatibility for callers that expect the info object to be populated.
I'm going to mark this as won't fix for now but leave it open to see if we get any consensus around one behavior or another.
from passport-jwt.
Marking as help wanted to encourage others to look at this and weigh in.
from passport-jwt.
Closing since i haven't heard anything in nearly a year.
from passport-jwt.
Related Issues (20)
- Disallow None algorithm by default HOT 6
- Project Status HOT 8
- Passport-jwt extractor fromUrlQueryParameter don't handle handshake requests (websocket) HOT 1
- I'm always unauthorized. HOT 2
- How to ignore ignoreExpiration for a specific endpoint? HOT 1
- Add Custom extractor which takes JwtFromRequestFunction as argument HOT 1
- Provide own jwt-verify option HOT 1
- Is cookieExtractor buggy?
- How to create new jwt Token HOT 1
- vulnerability in passport-jwt's dependancy jsonwebtoken HOT 7
- JWT verification for auth code or PKCE flow HOT 1
- jsonwebtoken update to ^9.0.0 in [email protected] was a breaking change HOT 1
- [email protected] > [email protected] vulnerability HOT 1
- TypeError: JwtStrategy requires a secret or key getting this error while running in node.js
- Passport authentication with JWTStrategy not working even jwt is not getting called even the console.log({ jwt_payload }); is not getting called HOT 2
- use `request.header(AUTH_HEADER)` instead of `request.headers[AUTH_HEADER]`
- Confirm if development is still active HOT 1
- MongooseError: Model.findOne() no longer accepts a callback
- Passport-jwt does not support edDSA algorithm for token verification
- Admin role product add time error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passport-jwt.