Python test test_variants_different_dtypes[brotli] sometimes times out about cramjam HOT 4 CLOSED

My first estimation would be that as this is the slowest codec, it's probably getting some larger inputs that is causing it to pass the deadline.

👍

I'm fine with extending the deadline, but as you mention other platforms may still struggle.

As a follow-up, I just got to the point where I was able to do a test build of a future python-cramjam package in COPR, and I found that the arbitrarily-chosen 10-second limit was enough for for the tests to succeed on all of Fedora’s primary architectures (x86_64, i686, ppc64le, aarch64, s390x) – at least once, and at least for the particular builder machines I happened to get this time. Obviously, there always exist other architectures and slower machines, and I may have gotten lucky with randomized inputs…

Slightly more inclined to limit the upper bound of the input lengths in hypothesis. Anything larger than the largest block size would probably be sufficient.

This wasn’t obvious to me, but seems more elegant if it proves to be sufficient. I’m happy to test a proposed change on the above-mentioned architectures, if that helps.

Thanks for the report. 👍

You’re welcome!

from cramjam.

Hrmm..I think I remember seeing this at least once before, but for whatever reason was taken up w/ something else.

My first estimation would be that as this is the slowest codec, it's probably getting some larger inputs that is causing it to pass the deadline. I'm fine with extending the deadline, but as you mention other platforms may still struggle. Slightly more inclined to limit the upper bound of the input lengths in hypothesis. Anything larger than the largest block size would probably be sufficient.

Thanks for the report. 👍

from cramjam.

I tested 67f6902 as a patch for the released Python package, version 2.7.0. As expected, it does appear to fix the timeouts on all Fedora primary architectures without needing to increase the deadline beyond one second.

from cramjam.

Great to hear, thanks for that @musicinmybrain!

from cramjam.