Comments (6)
All of the field names changed, check out FilterAbstract to see what they should be.
from decoda.
Hi Miles,
checked it and think it was map attributes which seems not be working correctly.
For example you've got the following configuration for a url tag.
...
'attributes' => array(
'target' => '/self|new/i'
),
'mapAttributes' => array(
't' => 'target'
),
...
and the string looks as following:
[url t="new"][/url]
In the old style you could use the alias parameter and it the parser handled it like the target attribute. Now I would need to add the t value as well to the attributes to have this correctly handled. (Which make it obsolete to define it in the mapping)
Reason is that in line 1016 in decoda.php only the source is checked for the key without consideration of the mapping. Do you see it as possible to bring back this behaviour?
from decoda.
I think the problem is that this line should be $finalKey instead of $key. The code is pretty much the same thing as it was before.
https://github.com/milesj/php-decoda/blob/master/Decoda.php#L1016
from decoda.
Tried it but then you get a problem with the url tag and the mapping of default to href.
I thought about it to check in https://github.com/milesj/php-decoda/blob/master/Decoda.php#L1016 both attributes, but then you've got still the problem that the pattern is not correctly loaded.
from decoda.
Ok, check out the latest master commit. This should fix it.
It still uses mapAttributes.
from decoda.
Thanks works fine :)
from decoda.
Related Issues (20)
- Emoticons not parsed when having the next to it HOT 3
- Uppercase Tags don't set defaults HOT 1
- Two bugs HOT 3
- Links and ClickableHook HOT 8
- Support for BBCode standalone tags? HOT 4
- caching HOT 2
- Problem with ulr tag which contain "_" HOT 2
- Force img tag to be https on https site HOT 3
- Support for [noparse] tag HOT 2
- Library Broken with PHP 7.3 HOT 2
- removeFilter('Video') Broken
- PHP5.6+? HOT 3
- Did not parse color if the color parameter is not enclosed with " HOT 1
- PHP7.2+ HOT 6
- Pass string as method argument HOT 3
- Use MediaEmbed for video filter HOT 1
- Normal "quotes" are not escaped HOT 4
- Url filter problems HOT 1
- Is there any way to use this without composer? HOT 1
- 6 UU
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from decoda.