Inconsistent behavior on return valut of CollectionResource#getChildren about milton2 HOT 9 OPEN

Ok, now I see, it was refactored a while ago.
Thanks.
But the changes will be available only in master branch, meaning - only for new versions.
You can update your implementation of CollectionResource to not return null but empty collection.

from milton2.

Which Java version do you use?
What I see here is
java.lang.NullPointerException: null
at java.base/java.util.ArrayList.addAll(ArrayList.java:702)
Array list throws an error on addAll.
Constructor of ArrayList doesn't use addAll - at least in recent versions of Java.
DeleteHelperImpl doesn't use any addAll calls.
I suspect it might be somewhere inside your CollectionResource implementation

from milton2.

java 11. Indeed, the constructor doesn't use addAll, but:

    public ArrayList(Collection<? extends E> c) {
        Object[] a = c.toArray();
        if ((size = a.length) != 0) {

Thus, c.toArray() will fail with NPE, if c is a null.

from milton2.

and if you look at the javadoc, then ist clearly stated:

   /**
     * Constructs a list containing the elements of the specified
     * collection, in the order they are returned by the collection's
     * iterator.
     *
     * @param c the collection whose elements are to be placed into this list
     * @throws NullPointerException if the specified collection is null
     */

from milton2.

Yes, I agree with javadoc. But what's confusing me - is the stacktrace
java.lang.NullPointerException: null
at java.base/java.util.ArrayList.addAll(ArrayList.java:702)
Why there is addAll?
I'm trying to reproduce it

List<? extends String> list = new ArrayList<>(null);
        for (String s : list) {
            System.out.println(s);
        }

Here small code
It gives different trace
Exception in thread "main" java.lang.NullPointerException
at java.base/java.util.ArrayList.(ArrayList.java:179)
at Main.main(Main.java:6)
And it throws it exactly at constructor, while in your case it is thrown in the for loop

from milton2.

we use milton 2.7.3

from milton2.

It doesn't reject the fact it fails not on the constructor, but on the addAll method.
Can you check you CollectionResource implementation - the getChildren method - if it executes somewhere addAll?

from milton2.

In tag 2.7.3 code looks like this:

		} else if (r instanceof CollectionResource) {
			CollectionResource col = (CollectionResource) r;
			List<Resource> list = new ArrayList<Resource>();
			list.addAll(col.getChildren());

https://github.com/miltonio/milton2/blob/2.7.3.0/milton-server-ce/src/main/java/io/milton/http/DeleteHelperImpl.java#LL62-L65C35

from milton2.