Giter VIP home page Giter VIP logo

Comments (23)

manuel-uberti avatar manuel-uberti commented on August 29, 2024 2

I am not using gccemacs at the moment, although I did try it in the past (i.e., before Vertico) without any problem and I am just waiting for it to be soon on master.

If @bbuccianti doesn't beat me to it, and this is not urgent, as soon as I can build master properly with native-comp I'll see if I can reproduce the problem and hopefully provide more details.

from vertico.

tsdh avatar tsdh commented on August 29, 2024 1

I've filed an emacs report here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47868

from vertico.

minad avatar minad commented on August 29, 2024

No idea, this is the same issue as #13. It is certainly not a Vertico issue if it only happens with native compilation. Do you manage to reproduce it with emacs -Q in the following modes? Please check that you use the newest Emacs 28 version.

  • interpreted/eval (does not seem like it from what you wrote about with eval-buffer)
  • byte-compiled
  • natively compiled

This should be discussed with Emacs upstream if you find a difference in behavior between these three evaluation modes.

@manuel-ubert is using Emacs 28 master (emacs-mirror/emacs@6de79542e4) and he has not observed issues.

from vertico.

bbuccianti avatar bbuccianti commented on August 29, 2024

I can confirm that with emacs -Q the issue only happen when running emacs-lisp-native-compile-and-load on vertico.el file. With intepreted and byte-compiled works properly.

from vertico.

minad avatar minad commented on August 29, 2024

Okay, do you use the newest emacs28 gccemacs? I guess Andrea Corrallo @Koral is interested if you find cases where gccemacs deviates from bytecompiled Emacs. You may want to create an upstream bug report, but please check the current version first.

from vertico.

bbuccianti avatar bbuccianti commented on August 29, 2024

I'm using fb08402a709896bc7ef95e50c7f14df2ea629814

For now, I just add "vertico" to comp-deferred-compilation-deny-list in order to avoid the native compilation.

Thanks, @minad !

from vertico.

manuel-uberti avatar manuel-uberti commented on August 29, 2024

Could you still report it to Emacs, please? It'd be good if Andrea or another Emacs maintainer with more knowledge on byte compilation can have a look at this.

from vertico.

minad avatar minad commented on August 29, 2024

CC @AndreaCorallo

from vertico.

manuel-uberti avatar manuel-uberti commented on August 29, 2024

I am not sure @AndreaCorallo will get a notification through an edit, so here is my kind ping. Andrea, if you get two notifications blame me, not Daniel. In that case, sorry about the noise.

from vertico.

AndreaCorallo avatar AndreaCorallo commented on August 29, 2024

I would be helpful if one of the vertico developers could investigate a little point out what's the function that is misbehaving.

from vertico.

minad avatar minad commented on August 29, 2024

I am not yet using Emacs28 gccemacs, so I cannot be of much help as of now. Maybe @manuel-uberti or @bbuccianti can help? I have no idea what causes this. If one assumes that there is some miscompilation I would expect to see errors at other different places.

from vertico.

minad avatar minad commented on August 29, 2024

See also minad/consult#274. The issue seems to be related to faces/strings, maybe strings which are mutated with properties. In Consult we saw issues with the following code:

         (consult--multi-align (propertize
                                " " ;; NOTE: Single space
                                'display
                                `(space :align-to (+ left ,(cadr candidates)))))

The odd behavior went away when doing this (cc @tumashu)

         (consult--multi-align (propertize
                                (substring-no-properties " ") ;; NOTE substring-no-properties
                                'display
                                `(space :align-to (+ left ,(cadr candidates)))))

         (consult--multi-align (propertize
                                "  " 'display ;; NOTE double space
                                `(space :align-to (+ left ,(cadr candidates)))))

This is also very odd and when I understood @tumashu correctly, they only observed it on gccemacs (20210330), but maybe that version was too old.

from vertico.

bdarcus avatar bdarcus commented on August 29, 2024

I see the same behavior, but no warnings in messages.

GNU Emacs 28.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.28, cairo version 1.17.4) of 2021-04-02

from vertico.

tumashu avatar tumashu commented on August 29, 2024

@minad maybe because I edit code then eval-buffer, which override eln, instead of add substring-no-properties

from vertico.

minad avatar minad commented on August 29, 2024

Ah okay, @tumashu in your case you simply reevaluate the code. You could also evaluate the original code and the error might go away.

from vertico.

minad avatar minad commented on August 29, 2024

@bdarcus Is this emacs master or gccemacs? Please report the exact version, there is the variable emacs-repository-version

from vertico.

bdarcus avatar bdarcus commented on August 29, 2024

@bdarcus Is this emacs master or gccemacs? Please report the exact version, there is the variable emacs-repository-version

I am on Fedora (34, beta), and use this copr package:

https://copr.fedorainfracloud.org/coprs/deathwish/emacs-pgtk-nativecomp/

That variable is nil.

Edit: that repo says last build was 1:28.0.50-1.20210402.gitfb08402.

from vertico.

bbuccianti avatar bbuccianti commented on August 29, 2024

I've tried .eln vertico and the problem it's there. But, after a few tries, seems like after eval only vertico--display-candidates the issue dissapeared. I don't know if that's helpful or not.

from vertico.

AndreaCorallo avatar AndreaCorallo commented on August 29, 2024

I suggest to verify the warnings in the *Async-native-compile-log* buffer related to the compilation of vertico.
One can also force the recompilation using native-compile-async if the package was compiled in a previous session.

from vertico.

minad avatar minad commented on August 29, 2024

@AndreaCorallo Thank you, that's helpful! Maybe @bbuccianti or @tumashu can post a log? Byte compilation of vertico is clean.

from vertico.

tumashu avatar tumashu commented on August 29, 2024

seem to no useful info.

Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compilation finished.
Compiling ~/.emacs.d/elpa-28/vertico-0.4/vertico.el...
Compilation finished.
Compiling /home/feng/.emacs.d/elpa-28/vertico-0.4/vertico.el...
Compilation finished.

from vertico.

bbuccianti avatar bbuccianti commented on August 29, 2024

Mine native compilation shows the same as @tumashu

Compiling /home/work/.emacs.d/straight/build/vertico/vertico.el...
Compilation finished.

The issue it's still there. If I can do anything to keep helping debug the problem, please tell me.

from vertico.

minad avatar minad commented on August 29, 2024

Closing here, bug is being worked on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47868

from vertico.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.